<Swing Dev> [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

[Rajeev Chamyal]

Hello All,

 

 

Please review the updated webrev.

 

http://cr.openjdk.java.net/~rchamyal/8147521/webrev.app.00/

 

Update: Added test case.

 

 

Regards,

Rajeev Chamyal

 

From: Rajeev Chamyal 
Sent: 06 May 2016 17:14
To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev at openjdk.java.net
Subject: <Swing Dev> [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

 

Hello All,

 

Please review the below 2 webrevs.

 

Webrev:

http://cr.openjdk.java.net/~rchamyal/8147521/webrev.app.00/

http://cr.openjdk.java.net/~rchamyal/8147521/webrev.app.01/

 

Bug : https://bugs.openjdk.java.net/browse/JDK-8147521

 

Approach 1:

http://cr.openjdk.java.net/~rchamyal/8147521/webrev.app.00/

 

A new protected API is provided in PopupFactory.java.

protected Popup getPopup(Component owner, Component contents, int x, int y,

boolean isHeavyWeightPopup)

 

Applications can override the new protected method and pass true value to isHeavyWeightPopup for forcing popup to be heavy weight.

Passing false will result in default behaviour.

 

Approach 2:

http://cr.openjdk.java.net/~rchamyal/8147521/webrev.app.01/

 

In this approach access level of existing methods setPopupType and getPopupType has been changed to protected.

Applications can override these methods to set or return different types of popups.

 

Following  values can be passed to setPopupType.

0 : LIGHT_WEIGHT_POPUP

1 : MEDIUM_WEIGHT_POPUP

2: HEAVY_WEIGHT_POPUP

 

 

Regards,

Rajeev Chamyal

 

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160509/c7271adb/attachment.html>