<Swing Dev> [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

[Rajeev Chamyal]

Hello All,

Please let me know your thoughts on the below webrev.
http://cr.openjdk.java.net/~rchamyal/8147521/webrev.02/

This approach is similar to Aqua as suggested by Sergey.

Regards,
Rajeev Chamyal

-----Original Message-----
From: Alexandr Scherbatiy 
Sent: 11 May 2016 01:16
To: Alan Snyder; swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup


Do you need to use medium-weight popups in your application or light/heavy-weight popups are enough?

Thanks,
Alexandr.

On 5/10/2016 10:23 PM, Alan Snyder wrote:
>> On May 10, 2016, at 5:58 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>>
>> Hi, Alan.
>> Can you please take a look to the proposed solutions? Thanks.
>>
>>
> Approach 2 matches what I currently do. The problem noted by Rajeev does not happen because my popup factory calls setPopupType() on each call to the public getPopup() before invoking the superclass method.
>
> I think the original version of Approach 1 would work. My factory would override the public getPopup() method and pass true to the five parameter method.
>
> I think the revised version of Approach 1 does not work for me because the new flag is only tested if the first attempt to create a popup fails.
>