<Swing Dev> [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

mikhail cherkasov mikhail.cherkasov at oracle.com
Wed May 11 14:20:54 UTC 2016


Hi all,

Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8078268
webrev:
http://cr.openjdk.java.net/~mcherkas/8078268/webrev.01/

The problem is in the following line:
http://hg.openjdk.java.net/jdk9/client/jdk/file/597626072716/src/java.desktop/share/classes/javax/swing/text/html/parser/Parser.java#l2127
for each new char it creates a string with a whole text inside the 
script tag, so it's very expensive operation.
I added check for <!-- and -->  by reading chars from input stream like 
it was done for end script tag.

Thanks,
Mikhail.



More information about the swing-dev mailing list