<Swing Dev> [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

Alexey Ivanov alexey.ivanov at oracle.com
Thu May 12 14:53:36 UTC 2016


Hi Mikhail,

On 12.05.2016 12:47, mikhail cherkasov wrote:
> On 5/12/2016 12:18 PM, Alexey Ivanov wrote:
>> HTMLEditorKit htmlKit = new HTMLEditorKit();
>> Document doc = htmlKit.createDefaultDocument();
>> htmlKit.read(new FileReader(...), doc, 0);
>
> Thank you for advice, this works fine:
> http://cr.openjdk.java.net/~mcherkas/8078268/webrev.03/
>

Great to hear it!

One small note though,

56 while (!parsingDone && System.currentTimeMillis() - s < 5_000) {

should also contain "exception == null" condition. If an exception was 
thrown, you already know the test failed, so there's no need to wait for 
timeout.


Regards,
Alexey



More information about the swing-dev mailing list