<Swing Dev> [9] Review request for JDK-7070795 High contrast colour scheme fails to be applied to JFormattedTextField

Alexandr Scherbatiy alexandr.scherbatiy at oracle.com
Mon May 23 17:00:44 UTC 2016


The fix looks good to me.

Thanks,
Alexandr.

On 5/23/2016 1:00 PM, Sergey Bylokhov wrote:
> Looks fine.
>
> On 23.05.16 12:08, Rajeev Chamyal wrote:
>> Hello Sergey,
>>
>> I have updated webrev as per review comments.
>>
>> http://cr.openjdk.java.net/~rchamyal/7070795/webrev.01/
>>
>> Regards,
>> Rajeev Chamyal
>>
>> -----Original Message-----
>> From: Sergey Bylokhov
>> Sent: 19 May 2016 20:30
>> To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev at openjdk.java.net
>> Subject: Re: <Swing Dev> [9] Review request for JDK-7070795 High 
>> contrast colour scheme fails to be applied to JFormattedTextField
>>
>> The fix looks fine. Note that in the test the count of characters for 
>> JFormattedTextFieldTest is set to 5, but 6 is used.
>>
>> On 19.05.16 18:25, Rajeev Chamyal wrote:
>>> Hello All,
>>>
>>>
>>>
>>> Please review the following webrev.
>>>
>>> Bug : https://bugs.openjdk.java.net/browse/JDK-7070795
>>>
>>> Webrev : http://cr.openjdk.java.net/~rchamyal/7070795/webrev.00/
>>>
>>>
>>>
>>> Issue: On changing the Windows theme to high contrast the high
>>> contrast color scheme is not getting applied to JFormattedTextFiled.
>>>
>>> Fix: Updated Formatted text field foreground and background properties.
>>>
>>>
>>>
>>> Regards,
>>>
>>> Rajeev Chamyal
>>>
>>
>>
>> -- 
>> Best regards, Sergey.
>>
>
>




More information about the swing-dev mailing list