<Swing Dev> Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac

[Avik Niyogi]

A gentle reminder. Please review the bug fix:
http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/>

With Regards,
Avik Niyogi

> On 25-May-2016, at 2:30 pm, Avik Niyogi <avik.niyogi at oracle.com> wrote:
> 
> Changes updated to same webrev.01
>> http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01 <http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01>
> With regards,
> Avik Niyogi
> 
>> On 25-May-2016, at 2:21 pm, Rajeev Chamyal <rajeev.chamyal at oracle.com <mailto:rajeev.chamyal at oracle.com>> wrote:
>> 
>> Looks ok to me.
>> Can you please add specific class imports instead of *.
>>  
>> Regards,
>> Rajeev Chamyal
>>  
>> From: Avik Niyogi 
>> Sent: 25 May 2016 12:53
>> To: Alexander Scherbatiy
>> Cc: Rajeev Chamyal; swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
>> Subject: Re: <Swing Dev> Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac
>>  
>> Hi All,
>>  
>> Please find updated changes as per inputs received:
>>  Bug: https://bugs.openjdk.java.net/browse/JDK-8144161 <https://bugs.openjdk.java.net/browse/JDK-8144161>
>>  
>> Webrev: http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/>
>>  
>> With Regards,
>> Avik Niyogi
>>  
>> On 24-May-2016, at 5:58 pm, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com <mailto:alexandr.scherbatiy at oracle.com>> wrote:
>>  
>> On 24/05/16 15:22, Avik Niyogi wrote:
>> Hi All, 
>>  
>> Kindly review the fix for JDK9.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8144161 <https://bugs.openjdk.java.net/browse/JDK-7124218>
>>  
>> Webrev:http:// <http:/>cr.openjdk.java.net/~aniyogi/8144161/webrev.00/ <http://cr.openjdk.java.net/%7Eaniyogi/8144161/webrev.00/>
>>  
>> Issue: Test case throws an exception when the behaviour is as expected.
>>  
>> Cause: The expected behaviour for comboBox was not accounted for Aqua look and feel in test case.
>>  
>> Fix: The test case was fixed to account for the Aqua LAF behaviour for comboBox dropdown menu which extends beyond the screen Insets (the dock height) for Mac.
>>  
>>   - the bug link points to the bug 7124218 instead of 8144161
>>   - The exception should be re-thrown on the line 63
>>   - Some code formatting change is not clear (see for example line 24 or 133)
>> 
>>   Thanks,
>>   Alexandr.
>> 
>> With Regards,
>> Avik Niyogi 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160527/e037eb8a/attachment.html>