<Swing Dev> [9] Review request for 8133731: [TEST_BUG] Unmappable in ASCII character such as Thai should be escaped in the regtests targeted for a regular non-I18n runs

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri May 27 14:38:21 UTC 2016


Looks fine.

On 27.05.16 17:21, Alexey Ivanov wrote:
> Hello Swing team,
>
> Could you please review the fix for jdk9:
>     bug: https://bugs.openjdk.java.net/browse/JDK-8133731
>     webrev: http://cr.openjdk.java.net/~aivanov/8133731/jdk9/webrev.00/
>
> Problem description:
> The java file is encoded as UTF-8, it uses Thai character 'ม' directly.
> In some cases, the test could fail to compile. Or it could test nothing.
> For me, the test passes on Windows with and without the fix for
> JDK-8076164 [1].
>
>
> The fix:
> Use Unicode escape for this character.
>
> As the result of this change, the test fails on builds without the fix
> for JDK-8076164 and passes on newer builds.
>
> I also organized imports and converted anonymous Runnable to lambda.
>
>
> Regards,
> Alexey
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8076164


-- 
Best regards, Sergey.



More information about the swing-dev mailing list