<Swing Dev> [9] Review request for 8058742: Text size is twice bigger under GTK L&F on Gnome with HiDPI enabled

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Nov 1 19:57:43 UTC 2016


On 05.10.16 10:35, Semyon Sadetsky wrote:
>> Can you clarify, what does it mean "wrong", this why we cannot use it
>> or what? If it is wrong then we can fix it, if it is correct why we
>> cannot use it? It should be the same as getNativeScale(), because it
>> is based on getNativeScale(), but unlike getNativeScale it is a public
>> API which is unrelated to X11.
> getNativeScale() returns the correct scale only on supported
> desktops/WMs. Currently they are gnome3 and Unity. My change doesn't
> affect other Linux distributions. What you are suggesting will change
> behavior on unsupported distributions. I don't see the reason to do this.

I do not understand this the GraphicsConfiguration.getDefaultTransform() 
is also uses getNativeScale() internally.

>>
>>>>
>>>> =======
>>>>>> since only in jdk9 on HiDPI screens default scale can have some
>>>>>> transform. The difference from the current solution is that the
>>>>>> shared
>>>>>> code will used the public/shared java2d api, instead of platform
>>>>>> specific.
>>>>>>
>>>>>>>>>>>  - Take debug scale into account if it was set and skip all
>>>>>>>>>>> others.
>>>>>>>>>>>  - Check J2D_UISCALE
>>>>>>>>>>>  - Check scale-factor, text-scale-factor, text-scaling-factor.
>>>>>>>>>>>  - Check Xft.dpi.
>>>>>>>>>>>  - If non of them was set then scale=1 should be used.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>


-- 
Best regards, Sergey.



More information about the swing-dev mailing list