<Swing Dev> [9] Review request for 8169719 WrappedPlainView.modelToView() should return Rectangle2D
Alexandr Scherbatiy
alexandr.scherbatiy at oracle.com
Tue Nov 15 17:18:47 UTC 2016
On 11/15/2016 5:08 PM, Sergey Bylokhov wrote:
> Should "@SuppressWarnings("deprecation")" be removed from this method?
> Why the test is linux and windows specific?
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8169719/webrev.01/
- "@SuppressWarnings("deprecation")"is removed
The test is not suitable for Mac OS X because chars advances on Mac
OS X have integer values.
Thanks,
Alexandr.
>
> On 15.11.16 16:49, Alexandr Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8169719
>> webrev: http://cr.openjdk.java.net/~alexsch/8169719/webrev.00
>>
>> WrappedPlainView.modelToView() method is updated to use
>> Utilities.getTabbedTextWidth() which returns floating point text width.
>>
>> Thanks,
>> Alexandr.
>>
>
>
More information about the swing-dev
mailing list