<Swing Dev> [9] RFR JDK-7190578: Nimbus: css test for 4936917 fails

Tue Nov 22 06:26:09 UTC 2016

Hi Sergey,

I saw in many tests in closed repo, blockTillDisplayed(swing comp) is 
called on non-EDT so did the same here.
Anyways, please find the updated webrev with editorPane accessed in EDT

http://cr.openjdk.java.net/~psadhukhan/7190578/webrev.03/

Regards
Prasanta
On 11/22/2016 3:58 AM, Sergey Bylokhov wrote:
> Hi, Prasanta
> Note that editorPane still accessed on non-EDT:
> ....
>         blockTillDisplayed(editorPane);
> ....
>         Point p = editorPane.getLocationOnScreen();
>
> On 18.11.16 14:11, Prasanta Sadhukhan wrote:
>> Updated test to access swing component on EDT and dispose frame at end
>> of test.
>>
>> Also, updated test to check background color (cccccc) and not white. But
>> it seems robot.getPixelColor() gives a spurious color for the 1st
>> location irrespective of what is the location, so used "match" variable
>> so that if there is more matches (bg color equals to cccccc) then make
>> test passed.
>> http://cr.openjdk.java.net/~psadhukhan/7190578/webrev.02/
>>
>> Regards
>> Prasanta
>> On 11/18/2016 2:37 PM, Ajit Ghaisas wrote:
>>> The test summary says that "Tests if background is correctly painted
>>> when <BODY> has css margins"
>>> In test, -background-color: #cccccc - is set as CSS, but a negative
>>> check is made with Color.white to fail the test.
>>> I think, we can improve the test to check for color set in CSS and
>>> fail if it is not set.
>>>
>>> Regards,
>>> Ajit
>>>
>>>
>>>
>>> -----Original Message-----
>>> From: Sergey Bylokhov
>>> Sent: Friday, November 18, 2016 2:23 PM
>>> To: Prasanta Sadhukhan; Alexandr Scherbatiy; Avik Niyogi;
>>> swing-dev at openjdk.java.net
>>> Subject: Re: <Swing Dev> [9] RFR JDK-7190578: Nimbus: css test for
>>> 4936917 fails
>>>
>>> On 18.11.16 11:44, Prasanta Sadhukhan wrote:
>>>> Any further objection on this? If not, can I get +1 ?
>>> It seems that there are some issues in the test:
>>>    - The Swing components accessed on the main thread instead of
>>> EDT(JEditorPane,JFrame);
>>>    - The JFrame should be disposed at the end of the test(when the
>>> test passed or failed).
>>>
>>>> Regards
>>>> Prasanta
>>>> On 11/16/2016 9:12 PM, Prasanta Sadhukhan wrote:
>>>>> Ok. Removed html file and updated test not to use JApplet. Please 
>>>>> find
>>>>> the updated webrev
>>>>>
>>>>> http://cr.openjdk.java.net/~psadhukhan/7190578/webrev.01/
>>>>>
>>>>>
>>>>> Regards
>>>>> Prasanta
>>>>> On 11/16/2016 7:55 PM, Sergey Bylokhov wrote:
>>>>>> It seems that the test has the main() method and ".html" file is not
>>>>>> necessary?
>>>>>>
>>>>>> On 16.11.16 12:38, Prasanta Sadhukhan wrote:
>>>>>>> I intended to open this testcase so remove dependancy on Util
>>>>>>> library.
>>>>>>> I tested with other LAFs and it passed.
>>>
>>
>
>