<Swing Dev> [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

[Alexandr Scherbatiy]

The fix looks good to me.

Thanks,
Alexandr.

On 10/14/2016 8:52 PM, Sergey Bylokhov wrote:
> On 03.10.16 12:35, Semyon Sadetsky wrote:
>>> But if layout was done, why we get any notifications? Should the check
>>> be (cnt != 0)?
>> Okay. I have changed it to zero:
>> http://cr.openjdk.java.net/~ssadetsky/8163167/webrev.01/
>
> Looks fine.
>
>>>
>>>>>
>>>>>>> I assume that each notification should be called when the size of
>>>>>>> JViewport or View were changed?
>>>>>>>
>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On 23.08.16 11:59, Alexander Scherbatiy wrote:
>>>>>>>>>>>>>>>> The fix looks good to me.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>>>> Alexandr.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On 23/08/16 11:40, Semyon Sadetsky wrote:
>>>>>>>>>>>>>>>>> Hello,
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Please review fix for JDK9:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8163167
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> webrev:
>>>>>>>>>>>>>>>>> http://cr.openjdk.java.net/~ssadetsky/8163167/webrev.00/
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> The cause of this test bug is revalidating JScrollPane
>>>>>>>>>>>>>>>>> layout may
>>>>>>>>>>>>>>>>> take
>>>>>>>>>>>>>>>>> various number of iterations on different L&Fs.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> To fix the test the counter listener is added after the
>>>>>>>>>>>>>>>>> layout
>>>>>>>>>>>>>>>>> revalidation has been started.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> --Semyon
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>