<Swing Dev> <AWT Dev> [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

[Semyon Sadetsky]

On 10/7/2016 4:21 PM, Sergey Bylokhov wrote:

> On 07.10.16 10:06, Semyon Sadetsky wrote:
>> Hi Sergey,
>>
>> After applying the patch I found 72 usages of the Event class. Why they
>> are not replaced?
>
> By the same reason why InputEvent.getModifiers() was not replaced by 
> InputEvent.getModifiersEx():
>
> >>>     We can replace old constants by the new one in the whole jdk, 
> but I
> >>>     updated only the code in InputEvent to make change smaller and
> >>>     safer. So at least the new code in jdk and the code in 
> applications
> >>>     will start to use the new constants.
But I didn't get why it is risky? Usually find&replace works reliably.

--Semyon
>
>
>> On 10/2/2016 4:53 PM, Sergey Bylokhov wrote:
>>> Thanks for the comments.
>>> The new version:
>>> http://cr.openjdk.java.net/~serb/8143077/webrev.01
>>> The specification of Event class and InputEvent.getModifiers() are
>>> updated.
>>>
>>> On 30.09.16 19:08, Jonathan Bluett-Duncan wrote:
>>>> Hi Sergey,
>>>>
>>>> I'm not a reviewer, but after reading the deprecation messages in
>>>> Event.java
>>>>
>>>>     * @deprecated It is recommended that {@code AWTEvent} class and 
>>>> its
>>>>     subclasses
>>>>     *             be used instead.
>>>>
>>>>
>>>> I get the impression they would read better without the redundant
>>>> "class" in the middle, like so.
>>>>
>>>>     * @deprecated It is recommended that {@code AWTEvent} and its
>>>> subclasses
>>>>     *             be used instead.
>>>>
>>>>
>>>> Kind regards,
>>>> Jonathan
>>>>
>>>>
>>>> On 30 September 2016 at 16:45, Sergey Bylokhov
>>>> <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> 
>>>> wrote:
>>>>
>>>>     Hello.
>>>>
>>>>     Please review the fix for jdk9.
>>>>
>>>>     This is request to deprecate the obsolete flags inside InputEvent.
>>>>     This constants were marked as obsolete in jdk1.4 and were replaced
>>>>     by the new one. In jdk1.4 the documentation were update with 
>>>> notion
>>>>     that the new constants should be used. And this bug is about
>>>>     official deprecation of them.
>>>>
>>>>     We can replace old constants by the new one in the whole jdk, 
>>>> but I
>>>>     updated only the code in InputEvent to make change smaller and
>>>>     safer. So at least the new code in jdk and the code in 
>>>> applications
>>>>     will start to use the new constants.
>>>>
>>>>     The changes in jconsole are necessary to fix deprecation warning.
>>>>
>>>>     jprt build passed, no new issues were found by jck/jtreg tests.
>>>>
>>>>
>>>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
>>>>     <https://bugs.openjdk.java.net/browse/JDK-8143077>
>>>>     Webrev can be found at:
>>>>     http://cr.openjdk.java.net/~serb/8143077/webrev.00
>>>> <http://cr.openjdk.java.net/~serb/8143077/webrev.00>
>>>>
>>>>     --
>>>>     Best regards, Sergey.
>>>>
>>>>
>>>
>>>
>>
>
>