<Swing Dev> [9] Review request for 8074883: Tab key should move to focused button in a button group

Alexandr Scherbatiy alexandr.scherbatiy at oracle.com
Tue Oct 25 12:14:30 UTC 2016


On 10/19/2016 8:14 PM, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8074883
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.00/
>
> To avoid unexpected selection change the selected button of a button 
> group should always grab focus when focus is transferred form 
> component outside the group to any unselected button inside the group 
> in case of traversal or initial container activation actions.
   - It is better to pass the cause and boolean focusInWindow arguments 
to the getGroupSelection() method to avoid some code duplication like 
switching over the same cause values.
   - The fix will require a CCC request because it updates a javadoc for 
the publci method.

   Thanks,
   Alexandr.
>
> --Semyon
>




More information about the swing-dev mailing list