<Swing Dev> [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

[Sergey Bylokhov]

On 27.10.16 9:45, Prasanta Sadhukhan wrote:
> What I meant to say is hidpi splashscreen support is not there in
> solaris (already told earlier too)
>
> http://mail.openjdk.java.net/pipermail/awt-dev/2016-March/010813.html

I think that it should be supported in some way already, because there 
is no such ifdef LINUX in the 
"Java_sun_awt_X11GraphicsDevice_getNativeScaleFactor" which is used in 
jdk.(Or probably it was not tested and does not work?).
Seems that this is a splashscreen limitation(I guess we just miss this 
when it was implemented). Please file a separate CR.

>
> and this
> http://hg.openjdk.java.net/jdk9/client/jdk/file/eeb8b31afed6/src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c#l809
>
> returns false if it is NOT linux which means we will get base image and
> not scaled image in solaris
>
> and this testcase is about hidpi splashscreen testing so it is not
> needed for solaris.
>
> Regards
> Prasanta
> On 10/26/2016 9:57 PM, Philip Race wrote:
>> Are you sure about that ? I can't think why it would not work on
>> Solaris just as it works everywhere else.
>>
>> And when I run 'java -help' on Solaris it lists the option :-
>>     -splash:<imagepath>
>>                   show splash screen with specified image
>>
>> -phil.
>>
>> On 10/26/16, 8:27 AM, Prasanta Sadhukhan wrote:
>>> No, as I understand splashscreen support is not there for solaris.
>>>
>>> Regards
>>> Prasanta
>>> On 10/26/2016 8:55 PM, Sergey Bylokhov wrote:
>>>> Should this test work on Solaris as well?
>>>>
>>>> On 26.10.16 10:19, Prasanta Sadhukhan wrote:
>>>>> Hi All,
>>>>>
>>>>> Please review a simple fix for splasscreen testissue where we need to
>>>>> restrict this test from running on linux as this test uses linux
>>>>> enviroment variable GDK_SCALE so
>>>>> restricting to run only on linux.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8168657
>>>>>
>>>>> diff -r aae3690e53e3
>>>>> test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
>>>>>
>>>>>
>>>>> ---
>>>>> a/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
>>>>>
>>>>> Thu Oct 20 14:21:46 2016 +0300
>>>>> +++
>>>>> b/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
>>>>>
>>>>> Wed Oct 26 12:46:56 2016 +0530
>>>>> @@ -47,6 +47,7 @@
>>>>>   * @test @bug 8145174 8151787
>>>>>   * @summary HiDPI splash screen support on Linux
>>>>>   * @modules java.desktop/sun.java2d
>>>>> + * @requires (os.family == "linux")
>>>>>   * @run main UnixMultiResolutionSplashTest
>>>>>   */
>>>>>  public class UnixMultiResolutionSplashTest {
>>>>>
>>>>>
>>>>> Regards
>>>>> Prasanta
>>>>
>>>>
>>>
>


-- 
Best regards, Sergey.