<Swing Dev> RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

Mandy Chung mandy.chung at oracle.com
Thu Oct 27 18:30:25 UTC 2016


> On Oct 27, 2016, at 10:44 AM, Phil Race <philip.race at oracle.com> wrote:
> 
> No, we are definitely shipping those.
> Unless of course you think we should stop shipping JNI headers too …
> 

No.  I tried to understand what is external interface.  I took it that these header files are external interfaces.

I reviewed:
  http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.05/index.html

Please move AccessBridgeCalls.c to  src/jdk.accessibility/windows/native/bridge directory.

Right now, the header files to be packaged in the JMOD file and linked into the image is white-listed in the makefile.

Ultimately, we want the entire directory to contain only header files for external interfaces and then the build can simply take all files under src/${MODULE}/share,${OS}/native/include and get rid of the hardcoded list in the makefile.  We are not there yet - one open issue is related to the duplicated header files in VM and JDK and some are private and some are external.  But we should prepare for that.

Mandy





More information about the swing-dev mailing list