<Swing Dev> [9] RFR JDK-8048702: Deprecate obsolete classes in javax/swing/plaf/metal/MetalFileChooserUI.java
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Fri Oct 28 19:35:08 UTC 2016
It seems that most of our deprecated api have an annotation and a
javadoc tag. I guess we should add javadoc tag here as well.
On 28.10.16 14:04, Alexandr Scherbatiy wrote:
>
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 10/28/2016 7:19 AM, Prasanta Sadhukhan wrote:
>> Please find the webrev with the proposed changes.
>>
>> http://cr.openjdk.java.net/~psadhukhan/8048702/
>>
>> Regards
>> Prasanta
>> On 10/27/2016 8:03 PM, Alexandr Scherbatiy wrote:
>>> On 10/26/2016 10:28 AM, Prasanta Sadhukhan wrote:
>>>> Hi All,
>>>>
>>>> Please review a fix for the issue where this obsolete class needs to
>>>> be deprecated:
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8048702
>>>>
>>>> diff -r aae3690e53e3
>>>> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java
>>>>
>>>> ---
>>>> a/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java
>>>> Thu Oct 20 14:21:46 2016 +0300
>>>> +++
>>>> b/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java
>>>> Wed Oct 26 12:56:48 2016 +0530
>>>> @@ -570,8 +570,9 @@
>>>> }
>>>>
>>>> /**
>>>> - * Obsolete class, not used in this version.
>>>> + * Obsolete class, not used in this version. deprecated as of
>>>> JDK version 9.
>>> - The deprecated word should start with the capital letter after
>>> the full stop.
>>>> */
>>>> + @Deprecated
>>> - since="1.9" can be added.
>>> - Could you provide the webrev for the fix?
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>>> protected class SingleClickListener extends MouseAdapter {
>>>> /**
>>>> * Constructs an instance of {@code SingleClickListener}.
>>>> @@ -583,8 +584,9 @@
>>>> }
>>>>
>>>> /**
>>>> - * Obsolete class, not used in this version.
>>>> + * Obsolete class, not used in this version. deprecated as of
>>>> JDK version 9.
>>>> */
>>>> + @Deprecated
>>>> @SuppressWarnings("serial") // Superclass is not serializable
>>>> across versions
>>>> protected class FileRenderer extends DefaultListCellRenderer {
>>>> }
>>>>
>>>> Regards
>>>> Prasanta
>>>
>>
>
--
Best regards, Sergey.
More information about the swing-dev
mailing list