<Swing Dev> [9] Review request for 8160054: The FileChooser didn't displayed large font with GTK LAF option.

[Sergey Bylokhov]

On 05.09.16 19:11, Semyon Sadetsky wrote:
>
> On 9/5/2016 6:55 PM, Sergey Bylokhov wrote:
>> On 02.09.16 12:50, Alexandr Scherbatiy wrote:
>>> The fix looks good to me.
>>
>> Probably the comment between .00 and .01 should be updated also?
>> "// if font property got different value then return it"
> I will change it to "got a value" upon the push if you don't mind.

ok

>>
>>
>>> On 9/2/2016 11:41 AM, Semyon Sadetsky wrote:
>>>> On 7/14/2016 6:31 PM, Alexandr Scherbatiy wrote:
>>>>
>>>>> On 6/27/2016 9:23 PM, Semyon Sadetsky wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Please review fix for JDK9:
>>>>>>
>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8160054
>>>>>>
>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8160054/webrev.00/
>>>>>>
>>>>>> The root case is GTK LnF does not allow to change its default fonts.
>>>>>>
>>>>>> The proposed solution let's to use LnF font properties to change the
>>>>>> defaults.
>>>>>  292         if (propFont != null && !font.equals(propFont)) {
>>>>>  293             // if font property got different value then
>>>>> return it
>>>>>  294             return propFont;
>>>>>  295         }
>>>>>
>>>>>   It looks like the !font.equals(propFont) condition is not necessary
>>>>> because when two fonts are equal it is right to return the propFont
>>>>> as well.
>>>> Please review the updated fix
>>>> http://cr.openjdk.java.net/~ssadetsky/8160054/webrev.01/
>>>>
>>>> --Semyon
>>>>>
>>>>>   Thanks,
>>>>>   Alexandr.
>>>>>>
>>>>>> --Semyon
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>>
>


-- 
Best regards, Sergey.