<Swing Dev> [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L&F on HiDPI display

[Alexandr Scherbatiy]

Hello,

Could you review the updated fix:
   http://cr.openjdk.java.net/~alexsch/8165485/webrev.01

  Round line end decoration is used to draw  combo box and scroll bar icons.

  [1], [2], and [3] screenshots show difference between icons
drawing before and after the fix for scales 1x, 2x, and 4x.

   [1] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-1x_01.png
   [2] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-2x_01.png
   [3] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-4x_01.png

   Thanks,
   Alexandr.

On 9/7/2016 7:54 PM, Phil Race wrote:
> drawPolyline does not seem to be an option here because of the 
> different colours.
> Filling custom shapes may be overkill. Round looks to me to be the 
> best of these three.
>
> -phil.
>
>
> On 9/7/2016 9:19 AM, Alexandr Scherbatiy wrote:
>> On 9/6/2016 6:10 PM, Sergey Bylokhov wrote:
>>> It seems that there are some small artifacts on some of the 
>>> components, please take a look to the corners of the selected 
>>> checkbox. In 1x the corners have correct edges but in x2,x4 there 
>>> are some missing pixels. Similar issue is in the text area(take a 
>>> look to the white border).
>>   Links [1], [2], and [3] shows drawing the scroll bar buttons using 
>> different types of a line ends decoration (cap, round, and square). 
>> All of them have one or another drawing artifact with scales 2 and 4.
>>
>>   [1] 
>> http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-butt.png
>>   [2] 
>> http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-round.png
>>   [3] 
>> http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-square.png
>>
>>   Thanks,
>>   Alexandr.
>>>
>>> On 06.09.16 13:18, Alexandr Scherbatiy wrote:
>>>>
>>>> Hello,
>>>>
>>>> Could you review the fix:
>>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8165485
>>>>   webrev: http://cr.openjdk.java.net/~alexsch/8165485/webrev.00
>>>>
>>>>   The icons drawing is changed to use ovals and polygons for
>>>> JRadioButton, JCheckBox, JComboBox, and JScrollBar.
>>>>
>>>>   The screenshots [1], [2], and [3] show difference between icons
>>>> drawing before and after the fix for scales 1x, 2x, and 4x.
>>>>
>>>>   [1]
>>>> http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-1x.png 
>>>>
>>>>   [2]
>>>> http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-2x.png 
>>>>
>>>>   [3]
>>>> http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-4x.png 
>>>>
>>>>
>>>>  Thanks,
>>>>  Alexandr.
>>>>
>>>>
>>>
>>>
>>
>