<Swing Dev> [9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L&F on HiDPI display
Andrej Golovnin
andrej.golovnin at gmail.com
Thu Sep 8 07:59:38 UTC 2016
Hi Alexandr,
> [1]
> http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-1x.png
The icons do not look right to me. Take look at the top-left part of
the radio button. There is a white pixel between the shadow lines. And
in the selected state there should be a black circle. But instead it
is a square. The check sign of the checkbox is too thin. And the
arrows of the combobox and the vertical scroll bar should have a
single pixel at the top/bottom side. But now they have two pixels.
It would be also nice to see a screen shot of the native Windows
components for comparison.
Personally when I would make changes like that, then my code would
look like this:
if (isNotHiDPI() || itMakesMoreSenseToUseTheOldCode()) {
// use the old good code.
} else {
// use the new code
}
Best regards,
Andrej Golovnin
> [2]
> http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x.png
> [3]
> http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x.png
>
> Thanks,
> Alexandr.
>
>
More information about the swing-dev
mailing list