<Swing Dev> [9] Review request for 8157065: There is no the focus border on the selected tab.

Alexandr Scherbatiy alexandr.scherbatiy at oracle.com
Mon Sep 12 15:20:03 UTC 2016


The paintTabbedPaneTabBorder() without orientation should be implemented 
as well because it can be accessed by public API.

Thanks,
Alexandr.

On 6/3/2016 10:54 PM, Semyon Sadetsky wrote:
>
>
> On 6/3/2016 10:34 PM, Sergey Bylokhov wrote:
>> On 03.06.16 22:21, Semyon Sadetsky wrote:
>>>> What reason? Why it is not public? since I provided the code example
>>>> where these methods are accessed by the user?
>>> GTK toollkit painting sequence is very different.
>>
>> What does it mean "different"? Even in this fix you implement one of 
>> the method according to the spec and skip the same method for some 
>> unknown reason.
>>
>>>>
>>>>> I still did not get why an overload method should have the same 
>>>>> behavior
>>>>> as its associates. This is a brand new design principle I've never 
>>>>> heard
>>>>> before.
>>>>
>>>> ...........
>>> That's nice...
>>> Do you have any other concerns?
>>
>> I still do not understand why the first method with default 
>> orientation is not implemented.
> I guess you meant "is not over-ridden". :) Once again: because it is 
> never used.
>




More information about the swing-dev mailing list