<Swing Dev> [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

Alexandr Scherbatiy alexandr.scherbatiy at oracle.com
Wed Sep 14 15:41:19 UTC 2016


On 9/14/2016 1:48 PM, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8154043
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8154043/webrev/
>
> The new RadioButton group focus traversal algorithm introduced by 
> JDK-8033699 doesn't take into account that group of radio buttons can 
> be lay-outed in several lines in container. In this case the 
> LayoutFocusTraversalPolicy may mix radio buttons of the same group 
> with other components in its focus traversal order and break the 
> assumption used in BasicRadioButtonUI#getFocusTransferBaseComponent() 
> that radio buttons are sequenced in the focus policy order.
>
> The fix propose to treat a group of toggle buttons as a single focus 
> cycle entry in the LayoutFocusTraversalPolicy which order is 
> determined by the first toggle button in the group.
   Should the test for the fix JDK-8033699 
test/javax/swing/JRadioButton/8033699/bug8033699.java be updated as well?

   Thanks,
   Alexandr.
>
> --Semyon
>
>




More information about the swing-dev mailing list