<Swing Dev> [9] Review request for 8165234 Provide a way to not close toggle menu items on mouse click on component level

[Sergey Bylokhov]

Hi, Alexandr.
I think we should double check how we operate on this property in case 
of custom L&F. Our code relies that this property is set to "true" by 
default. And if the custom look&feel, which knows nothing about it will 
be in use, then the code in SwingUtilities2 returns false. Is it expected?

On 05.09.16 13:51, Alexandr Scherbatiy wrote:
>
> Could you review the updated fix:
>   http://cr.openjdk.java.net/~alexsch/8165234/webrev.01
>
> On 9/2/2016 9:59 PM, Phil Race wrote:
>> Seems fine except for a grammatical issue in the javadoc
>>
>>  {@code true}. Setting the property to {@code false} either to
>> {@literal L&F}
>>
>> I think you mean ".. either on the ..."
>    The typo "either to" is updated to "either on the".
>
>   Thanks,
>   Alexandr.
>
>>
>> -phil.
>>
>> On 09/02/2016 05:30 AM, Alexandr Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the fix:
>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8165234
>>>   webrev: http://cr.openjdk.java.net/~alexsch/8165234/webrev.00
>>>
>>>   The fix JDK-8158566 adds "CheckBoxMenuItem.closeOnMouseClick" and
>>> "RadioButtonMenuItem.closeOnMouseClick" properties
>>>   that control toogle menu items closing on mouse click on L&F level.
>>>
>>>   The current fix allows to control menu items closing on a component
>>> level. A toogle menu item
>>>   is not closed on mouse click if the corresponding property is set
>>> to false either on the L&F or component level.
>>>
>>>  Thanks,
>>>  Alexandr.
>>>
>>
>


-- 
Best regards, Sergey.