<Swing Dev> [9] Review request for 8160160: The menu displayed nothing with the option"-server -d64 -Xmixed -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel".

[Semyon Sadetsky]

On 23.09.2016 15:52, Sergey Bylokhov wrote:

> On 01.09.16 14:21, Semyon Sadetsky wrote:
>> The proposed variant is better because if WM effects are switched off we
>> will receive this bug again.
>
> It should not be a problem because we will work in the similar way as 
> native popup menu.
> This version looks fine. Please fila a separate RFE to update menu 
> implementation to look as the native one, including the shadow.
https://bugs.openjdk.java.net/browse/JDK-8166621
Do you like it?
>
>>
>>
>> On 8/31/2016 10:29 PM, Sergey Bylokhov wrote:
>>> Did you try to force HW popups for GTK l&f? The current proposal will
>>> lead to the situation when popup will have different border depending
>>> on location in/out of the frame.
>>>
>>> On 31.08.16 10:54, Semyon Sadetsky wrote:
>>>> Hi Sergey,
>>>>
>>>> This is a valid concern. The fix is updated:
>>>> http://cr.openjdk.java.net/~ssadetsky/8160160/webrev.02/
>>>>
>>>> --Semyon
>>>>
>>>>
>>>> On 8/30/2016 11:10 PM, Sergey Bylokhov wrote:
>>>>> Hi, Semyon.
>>>>> I suggest to double check the HW menu/popups, they should have the
>>>>> correct border, because they should use the top level window, which
>>>>> should contains correct shadow effect. Note that after the fix we
>>>>> should not have two borers in such cases.
>>>>>
>>>>> On 29.08.16 20:11, Alexandr Scherbatiy wrote:
>>>>>>
>>>>>> The fix looks good to me.
>>>>>>
>>>>>> Thanks,
>>>>>> Alexandr.
>>>>>>
>>>>>> On 8/29/2016 7:08 PM, Semyon Sadetsky wrote:
>>>>>>> http://cr.openjdk.java.net/~ssadetsky/8160160/webrev.01/
>>>>>>>
>>>>>>> return type of ENGINE.finishPainting() changed to Buffered image.
>>>>>>>
>>>>>>> img.getRGB() returns a primitive not an object.
>>>>>>>
>>>>>>> --Semyon
>>>>>>>
>>>>>>>
>>>>>>> On 8/29/2016 3:45 PM, Alexandr Scherbatiy wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 8/29/2016 1:12 PM, Semyon Sadetsky wrote:
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> Please review fix for JDK9:
>>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8160160
>>>>>>>>>
>>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8160160
>>>>>>>>>
>>>>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8160160/webrev.00/
>>>>>>>>>
>>>>>>>>> The menu border is not painted by GTK Adwaita theme and makes 
>>>>>>>>> popup
>>>>>>>>> menu invisible at some circumstances.  To resolve this the GTK 
>>>>>>>>> menu
>>>>>>>>> border color is compared to the menu background color and if the
>>>>>>>>> same the border is painted by means of java graphics using a bit
>>>>>>>>> different color tone.
>>>>>>>>   - BufferedImage img = (BufferedImage) ENGINE.finishPainting();
>>>>>>>>   if the ENGINE.finishPainting() always returns BufferedImage it
>>>>>>>> would be better to change the return type to BufferedImage.
>>>>>>>>
>>>>>>>>   - border == img.getRGB(w / 2, h / 2)
>>>>>>>>   Could we rely on that img.getRGB(0, h / 2) returns the same 
>>>>>>>> object
>>>>>>>> as the img.getRGB(w / 2, h / 2)? May be it is use equals() methods
>>>>>>>> for comparing in this case.
>>>>>>>>
>>>>>>>>   Thanks,
>>>>>>>>   Alexandr.
>>>>>>>>>
>>>>>>>>> --Semyon
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>