<Swing Dev> RfR JDK-8160893 [macosx] JMenuItems in JPopupMenu are not accessible

Anton Tarasov anton.tarasov at jetbrains.com
Mon Sep 26 12:22:06 UTC 2016


Hi Pete,

The fix looks fine to me.

Thanks,
Anton.

On 9/24/2016 2:59 AM, Pete Brunet wrote:
> New webrev:
> http://cr.openjdk.java.net/~ptbrunet/JDK-8160893/webrev.02/
>
> I added a null check at line 688 like the one at line 693.
>
> Pete
>
> On 9/23/16 2:46 PM, Pete Brunet wrote:
>> Please review the patch for JDK-8160893.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8160893
>> Patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8160893/webrev.01/
>>
>> This patch adds support to post menu related events:
>> kAXMenuOpenedNotification, kAXMenuClosedNotification, and
>> kAXMenuItemSelectedNotification.  Also note that these changes had
>> impacts on the current combo box behavior so you'll see combo boxes
>> filtered out from this fix.  The combo box behavior is currently broken
>> and will be fixed at a later date but at least for now I didn't want
>> this patch to change that (broken) behavior.
>>
>> TiA,
>> Pete




More information about the swing-dev mailing list