<Swing Dev> [9] Review request for 8153522: Update JLightweightFrame to allow non-integer (and X/Y) scales

[Kevin Rushforth]

Semyon Sadetsky wrote:
>
>
> On 9/30/2016 7:23 PM, Kevin Rushforth wrote:
>>
>>
>> Sergey Bylokhov wrote:
>>> On 29.09.16 17:13, Semyon Sadetsky wrote:
>>>> On 9/29/2016 3:51 PM, Sergey Bylokhov wrote:
>>>>
>>>>> Why we need the old API since it is sun.awt package?
>>>> For compatibility. SwingNode doesn't yet use the new one.
>>>
>>> Probably Kevin can provide some info on how we usually synchronize 
>>> the changes between jdk and FX, I assume that we should save the old 
>>> one and remove them after FX will use it as a boot/minimum jdk?
>>
>> Yes, that is how we would typically do this. And to add to the 
>> problem for JDK 9, we are stuck building FX with jdk-9+109 until 
>> https://bugs.openjdk.java.net/browse/JDK-8161704 is fixed.
>>
>> -- Kevin
> Did you mean I need to keep both class versions (old and new) with 
> different names?
> But the old class version is not required for compilation. You will be 
> able to build FX using b109 after the fix.

As long as FX (built with 109 as boot JDK) will also continue to run on 
the latest JDK then that's what matters. I haven't actually looked at 
the change to see whether there is a problem. I was just answering the 
general question of how we usually migrate to new JDK API to avoid 
breaking things.

-- Kevin



>
> --Semyon
>>
>>
>>>> And there are may be some external apps has been using this API. No?
>>>
>>> It will not be accessible to applications in jdk.
>>>
>>>>>
>>>>> On 29.09.16 10:55, Semyon Sadetsky wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Please review fix for JDK9:
>>>>>>
>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8153522
>>>>>>
>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8153522/webrev.00/
>>>>>>
>>>>>> LightweightFrame Swing embedding API is updated for capability with
>>>>>> floating point scale to make JavaFX SwingNode correctly shown on 
>>>>>> Windows
>>>>>> platform.
>>>>>>
>>>>>> Backward API compatibility is preserved but methods with old 
>>>>>> signatures
>>>>>> are marked as deprecated.
>>>>>>
>>>>>> --Semyon
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>