<Swing Dev> [9] Review Request: 8177450: javax.swing.text.html.parser.Parser parseScript ignores a character after commend end

Mikhail Cherkasov mikhail.cherkasov at oracle.com
Wed Apr 5 10:36:10 UTC 2017


Hi Phil,

On 4/4/2017 9:13 PM, Phil Race wrote:
> 2122 if(i > 0) { should be "if (i > 0) {"
fixed: http://cr.openjdk.java.net/~mcherkas/8177450/9/webrev.01/
> Can you comment on what tests have been run to ensure this does not 
> regress anything else ?
I run tests from " test/javax/swing/text/html/parser/" and from 
"test/closed/javax/swing/text/html/parser/"
no new failures, also I run swing JCK tests and again no new failures.
> -phil.
>
>
> On 03/31/2017 04:28 AM, Mikhail Cherkasov wrote:
>> Hello,
>>
>> Could you please review the fix for jdk9?
>>
>> The problem is that Parser reads extra symbol after comment or script tag and missed the symbol.
>> I added 'continue' after those tags, so it goes to beginning of Parser while loop and process the symbol.
>>    
>> Bug:https://bugs.openjdk.java.net/browse/JDK-8177450
>> Webrev:http://cr.openjdk.java.net/~mcherkas/8177450/9/webrev/
>>
>> Thanks,
>> Mikhail.
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20170405/a2877d62/attachment.html>


More information about the swing-dev mailing list