<Swing Dev> [10] RFR JDK-7190539:Nimbus LaF: JPopupMenu reacts on Ctrl+Enter.

Alexander Zvegintsev alexander.zvegintsev at oracle.com
Tue Jul 4 06:52:13 UTC 2017


+1

Thanks,
Alexander.

On 03/07/2017 21:02, Semyon Sadetsky wrote:
> Looks good.
>
> --Semyon
>
>
> On 07/03/2017 08:14 AM, Prasanta Sadhukhan wrote:
>> oops. webrev with modified testcase
>>
>> http://cr.openjdk.java.net/~psadhukhan/7190539/webrev.02/
>>
>> Regards
>> Prasanta
>> On 7/3/2017 8:11 PM, Semyon Sadetsky wrote:
>>> Hi Prasanta,
>>>
>>> Can you change the test to make it follow the Swing EDT rule.
>>>
>>> --Semyon
>>>
>>>
>>> On 07/03/2017 01:58 AM, Prasanta Sadhukhan wrote:
>>>> Modified testcase to iterate over all installed l&fs and extended 
>>>> fix to Motif L&F too.
>>>>
>>>> http://cr.openjdk.java.net/~psadhukhan/7190539/webrev.01/
>>>>
>>>> Regards
>>>> Prasanta
>>>> On 7/3/2017 1:21 PM, Prasanta Sadhukhan wrote:
>>>>> Hi All,
>>>>>
>>>>> Please review a fix for an issue where when a JPopupMenu is 
>>>>> displayed, an underlying Default JButton still responds to the 
>>>>> CTRL-ENTER keystroke
>>>>> for NimbusLookAndFeel.
>>>>> This is a continuation to JDK-4870644 fix where it is fixed for 
>>>>> Basic L&F.
>>>>> The problem there was that we do not override ctrl ENTER action 
>>>>> that registered in the patent container as "press default button".
>>>>> The idea of the fix is to override this binding with the "press 
>>>>> selected menu item" action.
>>>>>
>>>>> The same fix is extender to Nimbus L&F.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-7190539
>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/7190539/webrev.00/
>>>>>
>>>>> Regards
>>>>> Prasanta
>>>>
>>>
>>
>




More information about the swing-dev mailing list