<Swing Dev> [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

[Prasanta Sadhukhan]

Thanks Semyon for spotting this. Since this bug is for windows, I 
concentrated on windows only.

But it seems, for non-windows platform, ShellFolder uses
COLUMN_NAME = "FileChooser.fileNameHeaderText";
COLUMN_SIZE = "FileChooser.fileSizeHeaderText";
COLUMN_DATE = "FileChooser.fileDateHeaderText";
string which is locale-sensitive.

Only for windows, it uses Win32ShellFolder which calls 
IShellDetails::GetDetailsOf() to get columns details.
Modified webrev applicable for only windows to convert this windows 
specific names to locale-sensitive names.

http://cr.openjdk.java.net/~psadhukhan/8183529/webrev.01/

Regards
Prasanta
On 7/5/2017 8:40 PM, Semyon Sadetsky wrote:
>
> Hi Prasanta,
>
> Haven't you tested how the details header localization works after 
> your fix with other L&Fs and platforms?
>
> --Semyon
>
>
> On 07/04/2017 11:42 PM, Prasanta Sadhukhan wrote:
>> Hi All,
>>
>> Please review a fix for a locale issue where it is seem FileChooser 
>> dialog is not showing the column heading
>> in selected locale in "Detail view mode".
>> This was because, even though the locale strings are present in 
>> properties resource file,
>> /share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties//
>> //FileChooser.fileNameHeader.textAndMnemonic=Name//
>> //FileChooser.fileSizeHeader.textAndMnemonic=Size//
>> /the check done is wrong.
>>
>> Proposed fix is to check and get locale string resources correctly.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8183529
>> webrev: http://cr.openjdk.java.net/~psadhukhan/8183529/webrev.00/
>>
>> Regards
>> Prasanta
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20170706/fd545192/attachment.html>