<Swing Dev> [10] RFR 6962725:Regtest javax/swing/JFileChooser/6738668/bug6738668.java fails under Linux

Sergey Bylokhov sergey.bylokhov at oracle.com
Tue Jun 6 02:55:55 UTC 2017


Thanks. The fix looks fine.

> 
> Thanks Sergey. I confirm new test fails with 7b40 in jtreg and pass with 9b170.
> 
> Regards
> Prasanta
> On 6/1/2017 9:12 PM, Sergey Bylokhov wrote:
>> Hi, Prasanta.
>> You should set a JT_JAVA environment variable to jdk8 or jdk9 before running jtreg:
>> http://openjdk.java.net/jtreg/runtests.html
>> 
>> This java will be used to start a jtreg itself. And for the test the java passed to "-jdk" will be used.
>> 
>> ----- prasanta.sadhukhan at oracle.com wrote:
>> 
>>> I could not run jdk7u40 build with my jtreg harness as it cites the
>>> below problem. I do not have jtreg older than 4.2b03, nor I could find
>>> 
>>> in jtreg site.
>>> 
>>> PRSADHUK-IN+prsadhuk at PRSADHUK-IN /cygdrive/c/jdk9/jtreg-42b03
>>> $ ./bin/jtreg -jdk:/cygdrive/d/Vbox_Shared/JDK/jdk1.7.0-b40/fastdebug/
>>> 
>>> /cygdrive/d/jdk7u/jdk7u-dev/jdk/test/javax/swing/JFileChooser/6738668/bug6738668.java
>>> java.lang.UnsupportedClassVersionError:
>>> com/sun/javatest/regtest/JDK$Fault : Unsupported major.minor version
>>> 52.0
>>>          at java.lang.ClassLoader.defineClass1(Native Method)
>>>          at java.lang.ClassLoader.defineClass(ClassLoader.java:642)
>>> 
>>> Regards
>>> Prasanta
>>> On 5/30/2017 10:28 PM, Sergey Bylokhov wrote:
>>>> The new version fails even if run via jtreg?
>>>> 
>>>> ----- prasanta.sadhukhan at oracle.com wrote:
>>>> 
>>>>> OK. With revised command line, it fails with new updated test in
>>> 7b40
>>>>> and passed in 9b170
>>>>> 
>>>>> /cygdrive/d/Vbox_Shared/JDK/jdk1.7.0-b40/fastdebug/bin/java
>>>>> -Djava.security.manager -Djava.security.policy=security.policy
>>>>> bug6738668
>>>>> tmp dir C:\cygwin64\tmp\
>>>>> Exception in thread "main" java.security.AccessControlException:
>>>>> access
>>>>> denied (java.io.FilePermission
>>>>> C:\Users\prsadhuk\AppData\Roaming\Microsoft\Windows\Recent read)
>>>>>           at
>>>>> 
>>> java.security.AccessControlContext.checkPermission(AccessControlContext.java:345)
>>>>>           at
>>>>> 
>>> java.security.AccessController.checkPermission(AccessController.java:555)
>>>>>           at
>>>>> 
>>> java.lang.SecurityManager.checkPermission(SecurityManager.java:549)
>>>>>           at
>>>>> java.lang.SecurityManager.checkRead(SecurityManager.java:888)
>>>>> 
>>>>> /cygdrive/d/Vbox_Shared/JDK/jdk9-b170/fastdebug/bin/java
>>>>> -Djava.security.manager -Djava.security.policy=security.policy
>>>>> bug6738668
>>>>> tmp dir C:\cygwin64\tmp\
>>>>> Test passed for LookAndFeel
>>> javax.swing.plaf.metal.MetalLookAndFeel
>>>>> tmp dir C:\cygwin64\tmp\
>>>>> Test passed for LookAndFeel
>>> javax.swing.plaf.nimbus.NimbusLookAndFeel
>>>>> tmp dir C:\cygwin64\tmp\
>>>>> Test passed for LookAndFeel
>>>>> com.sun.java.swing.plaf.motif.MotifLookAndFeel
>>>>> tmp dir C:\cygwin64\tmp\
>>>>> Test passed for LookAndFeel
>>>>> com.sun.java.swing.plaf.windows.WindowsLookAndFeel
>>>>> tmp dir C:\cygwin64\tmp\
>>>>> Test passed for LookAndFeel
>>>>> com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel
>>>>> 
>>>>> Regards
>>>>> Prasanta
>>>>> On 5/30/2017 2:59 AM, Sergey Bylokhov wrote:
>>>>>> I guess you will need to set security manager which will use your
>>>>> policy file:
>>>>> 
>>> https://docs.oracle.com/cd/E13222_01/wls/docs81b/secmanage/java.html
>>>>>> ----- prasanta.sadhukhan at oracle.com wrote:
>>>>>> 
>>>>>>> I am not sure why it is passing in my case. I thought it might
>>> be
>>>>>>> taking
>>>>>>> in some other security policy so I renamed and use a different
>>>>> named
>>>>>>> policy but it still passed in my windows 7.
>>>>>>> 
>>>>>>> $ /cygdrive/d/Vbox_Shared/JDK/jdk1.7.0-b40/fastdebug/bin/java
>>>>>>> -Djava.security.policy=my.policy bug6738668
>>>>>>> Test passed for LookAndFeel
>>>>> javax.swing.plaf.metal.MetalLookAndFeel
>>>>>>> Test passed for LookAndFeel
>>>>>>> com.sun.java.swing.plaf.motif.MotifLookAndFeel
>>>>>>> Test passed for LookAndFeel
>>>>>>> com.sun.java.swing.plaf.windows.WindowsLookAndFeel
>>>>>>> Test passed for LookAndFeel
>>>>>>> com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel
>>>>>>> 
>>>>>>> PRSADHUK-IN+prsadhuk at PRSADHUK-IN
>>>>>>> 
>>> /cygdrive/d/jdk10/client/jdk/test/javax/swing/JFileChooser/6738668
>>>>>>> $ cat my.policy
>>>>>>> grant {
>>>>>>>        permission java.io.FilePermission "C:\\temp\\*", "read";
>>>>>>>        permission java.io.FilePermission "C:\\temp", "read";
>>>>>>>        permission java.util.PropertyPermission "*", "read";
>>>>>>> };
>>>>>>> 
>>>>>>> PRSADHUK-IN+prsadhuk at PRSADHUK-IN
>>>>>>> 
>>> /cygdrive/d/jdk10/client/jdk/test/javax/swing/JFileChooser/6738668
>>>>>>> $ /cygdrive/d/Vbox_Shared/JDK/jdk1.7.0-b40/fastdebug/bin/java
>>>>>>> -version
>>>>>>> java version "1.7.0-ea-fastdebug"
>>>>>>> Java(TM) SE Runtime Environment (build 1.7.0-ea-fastdebug-b40)
>>>>>>> Java HotSpot(TM) 64-Bit Server VM (build 14.0-b07-fastdebug,
>>> mixed
>>>>>>> mode)
>>>>>>> 
>>>>>>> BTW, does my updated test fail in your environment with b40?
>>>>>>> 
>>>>>>> Regards
>>>>>>> Prasanta
>>>>>>> On 5/28/2017 4:10 AM, Sergey Bylokhov wrote:
>>>>>>>> There is a comment that JDK-6738668 a regression of JDK-6484091
>>>>>>> which was pushed to b20.
>>>>>>>> I just checked the test from the command line on b40 and it
>>>>> fails,
>>>>>>> but passed on b55.
>>>>>>>> Can you please check why it was passed in your case.
>>>>>>>> 
>>>>>>>> ----- prasanta.sadhukhan at oracle.com wrote:
>>>>>>>> 
>>>>>>>>> Hi Sergey,
>>>>>>>>> 
>>>>>>>>> I do not see any comment mention about failure in 7b20 but
>>>>> anyways,
>>>>>>> I
>>>>>>>>> tried with 7b20,7b30,7b40,7b50 and all of them passed with
>>>>>>> original
>>>>>>>>> and
>>>>>>>>> updated test in windows.
>>>>>>>>> 
>>>>>>>>> Regards
>>>>>>>>> Prasanta
>>>>>>>>> On 5/25/2017 2:30 AM, Sergey Bylokhov wrote:
>>>>>>>>>> I am not sure but according to the comments of JDK-6738668 it
>>>>> was
>>>>>>> a
>>>>>>>>> regression in 7b20.
>>>>>>>>>> So I suggest to check a few build between b20 and b54
>>>>>>>>>> 
>>>>>>>>>> ----- prasanta.sadhukhan at oracle.com wrote:
>>>>>>>>>> 
>>>>>>>>>>> Hi Sergey,
>>>>>>>>>>> 
>>>>>>>>>>> No, it is passing. Actually, the original test is also
>>> passing
>>>>>>>>> with
>>>>>>>>>>> 1.7.0 b05 (6738668 is supposedly fixed in 7b55), there's no
>>>>>>>>>>> SecurityException
>>>>>>>>>>> 
>>>>>>>>>>> jdk1.7.0/bin/java -Djava.security.policy=security.policy
>>>>>>>>> bug6738668
>>>>>>>>>>> Test passed for LookAndFeel
>>>>>>>>> javax.swing.plaf.metal.MetalLookAndFeel
>>>>>>>>>>> Test passed for LookAndFeel
>>>>>>>>>>> com.sun.java.swing.plaf.motif.MotifLookAndFeel
>>>>>>>>>>> Test passed for LookAndFeel
>>>>>>>>>>> com.sun.java.swing.plaf.windows.WindowsLookAndFeel
>>>>>>>>>>> Test passed for LookAndFeel
>>>>>>>>>>> com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel
>>>>>>>>>>> 
>>>>>>>>>>> jdk1.7.0/bin/java -version
>>>>>>>>>>> java version "1.7.0-ea"
>>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.7.0-ea-b05)
>>>>>>>>>>> Java HotSpot(TM) 64-Bit Server VM (build 1.7.0-ea-b05, mixed
>>>>>>> mode)
>>>>>>>>>>> Regards
>>>>>>>>>>> Prasanta
>>>>>>>>>>> On 5/24/2017 11:48 AM, Sergey Bylokhov wrote:
>>>>>>>>>>>> Hi, Prasanta.
>>>>>>>>>>>> Please confirm that the updated test fails before
>>> JDK-6738668
>>>>>>> was
>>>>>>>>>>> fixed.
>>>>>>>>>>>>> Hi ALl,
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Please review a testbug fix for an issue where this
>>>>> regression
>>>>>>>>> test
>>>>>>>>>>> is failing in linux because
>>>>>>>>>>>>> JFileChooser was trying to access C:/temp path which does
>>>>> not
>>>>>>>>> exist
>>>>>>>>>>> in linux.
>>>>>>>>>>>>> Proposed fix is to use java.io.tmpdir instead of hardcoded
>>>>>>>>> windows
>>>>>>>>>>> path.
>>>>>>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-6962725
>>>>>>>>>>>>> webrev:
>>>>>>>>> http://cr.openjdk.java.net/~psadhukhan/6962725/webrev.00/
>>>>>>>>>>>>> Regards
>>>>>>>>>>>>> Prasanta
> 




More information about the swing-dev mailing list