<Swing Dev> [10] RFR: JDK-8181782:[TESTBUG] [Macosx] JTextAreaEmojiTest is not executed

[Avik Niyogi]

Fix looks good to me.

> On 13-Jun-2017, at 5:30 pm, swing-dev-request at openjdk.java.net wrote:
> 
> Date: Mon, 12 Jun 2017 07:21:13 -0700 (PDT)
> From: Sreeprakash Sreedharan <sreeprakash.s at oracle.com <mailto:sreeprakash.s at oracle.com>>
> To: Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com <mailto:prasanta.sadhukhan at oracle.com>>,
> 	swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
> Subject: Re: <Swing Dev> [10] RFR: JDK-8181782:[TESTBUG] [Macosx]
> 	JTextAreaEmojiTest is not executed
> Message-ID: <9c1fbf5c-e872-414e-84c1-fa533a21e1aa at default>
> Content-Type: text/plain; charset=utf-8
> 
> Thanks for the inputs, Prasanta. 
> 
> I have incorporated the changes mentioned.
> 
> Updated Webrev :  http://cr.openjdk.java.net/~rpatil/8181782/webrev.01 <http://cr.openjdk.java.net/~rpatil/8181782/webrev.01>
> 
> Regards,
> Sreeprakash
> 
> -----Original Message-----
> From: Prasanta Sadhukhan 
> Sent: Monday, June 12, 2017 2:55 PM
> To: Sreeprakash Sreedharan <sreeprakash.s at oracle.com <mailto:sreeprakash.s at oracle.com>>; swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
> Subject: Re: <Swing Dev> [10] RFR: JDK-8181782:[TESTBUG] [Macosx] JTextAreaEmojiTest is not executed
> 
> It seems the test is waiting infinitely instead of having a timeout. I amnot sure of jtreg timeout but it's better to rely on test's own timeout, so await(timeout) is a better call .
> 
> Also, please add @key headful tag to the test.
> 
> Regards
> Prasanta
> On 6/9/2017 1:38 AM, Sreeprakash Sreedharan wrote:
>> Hi All,
>> 
>> Kindly review the fix for JDK10.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8181782 <https://bugs.openjdk.java.net/browse/JDK-8181782>
>> 
>> Webrev: http://cr.openjdk.java.net/~rpatil/8181782/webrev.00 <http://cr.openjdk.java.net/~rpatil/8181782/webrev.00>
>> 
>> Issue: JTREG was not executing the manual test JTextAreaEmojiTest and was always giving a passed result.
>> 
>> Fix: Made sure that main function waits for pass/fail events using a 
>> countdown latch and also added manual to the run tag
>> 
>> Regards,
>> Sreeprakash
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20170614/e9412f15/attachment.html>