<Swing Dev> [9][TESTBUG]: Review Request for JDK-8169957: javax/swing/JScrollBar/4708809: The scrollbar moved with incorrect direction

[Sergey Bylokhov]

Hi, Srinivas.
Can you please clarify the fix a little bit. You changed the type of the frame to the NORMAL, but this is a default type. So it is unclear what was the reason of the test failure.
Also please add a code which will dispose the frame at the end of the test.

> 
> Hi All,
>  
> Please review the test bug fix for JDK-8169957: javax/swing/JScrollBar/4708809: The scrollbar moved with incorrect direction.
>  
> Regards,
> Srinivas M
>  
> From: Srinivas Mandalika 
> Sent: Monday, June 12, 2017 1:50 PM
> To: swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
> Subject: <Swing Dev> [9][TESTBUG]: Review Request for JDK-8169957: javax/swing/JScrollBar/4708809: The scrollbar moved with incorrect direction
>  
> Hi All,
>  
> Please review the test bug fix for JDK-8169957: javax/swing/JScrollBar/4708809: The scrollbar moved with incorrect direction.
>  
> Issue:
> This test checks whether a scrollbar drag moves in the correct direction. This behavior is working as expected when tested manually. The test was failing robot clicks out of sync with the yet to be maximized frame.
>  
> Fix:
> Ensure the robot waits for the frame to be maximized before the scroll actions. Also ensure the main application frame is maximized explicitly.
>  
> Testing: 
> Tested the potential fix on winx64, linux  with JDK8, 9 several times with running tests individually clubbed with the previous test and the entire suite (i.e javax/swing) put to ensure that the issue is not repeated.
>  
> Bug Id: https://bugs.openjdk.java.net/browse/JDK-8169957 <https://bugs.openjdk.java.net/browse/JDK-8169957>
> Webrev: http://cr.openjdk.java.net/~akolarkunnu/8169957/webrev.00/ <http://cr.openjdk.java.net/~akolarkunnu/8169957/webrev.00/>
>  
> Thanks
> Srinivas M

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20170619/4a25a583/attachment.html>