<Swing Dev> [10] RFR JDK-8182402:Tooltip for Desktop button is in English when non-English locale is set

[Alexander Zvegintsev]

Looks good to me.

Thanks,
Alexander.

On 21/06/2017 14:13, Prasanta Sadhukhan wrote:
> Hi All,
>
> Please review a fix for an issue where tooltip for "Home" or Desktop 
> button is in English even though locale is non-English.
> This is because even though i18n properties has
> FileChooser.homeFolderToolTip.textAndMnemonic=Home
> in English, Dutch,chinese etc
> ./share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties
> share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties
>
> in MetalFileChooserUI.java and SynthFileChooserUIImpl.java, it is 
> replaced by "Desktop" text which do not have corresponding i18N resources.
> There is a corresponding bug JDK-8179346 
> <https://bugs.openjdk.java.net/browse/JDK-8179346> which says pressing 
> "home" button should not go to Desktop so probably desktop is not 
> correct name for home folder.
>
> Proposed fix is to use "Home" tooltip text so that it can be displayed 
> in different locale.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8182402
> webrev: http://cr.openjdk.java.net/~psadhukhan/8182402/webrev.00/
>
> Regards
> Prasanta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20170630/f4d073cb/attachment.html>