<Swing Dev> [9] Review request for 8174845 Bad scaling on Windows with large fonts with Java 9ea

[Philip Race]

I see the fix was just pushed. But my comments are clearly not addressed.

-phil.

On 3/15/17, 10:11 AM, Philip Race wrote:
> Does this actually try to address everything they complained about here
>
> http://stackoverflow.com/questions/41117190/java-9-on-windows-with-large-fonts 
>
> which points to an image : https://i.stack.imgur.com/fgpBu.png
>
> Check boxes are some of it but not all of it.
>
> There is what appears to be a custom icon there - the black outlined
> yellow zig-zg shape - and I don't see how we can draw that ourselves.
>
> Which is why I asked in the bug report if we had looked at how we are 
> doing image scaling.
> It may be that we are already doing the best we can but I don't know 
> that ..
>
> -phil.
>
> On 3/15/17, 8:35 AM, Sergey Bylokhov wrote:
>>> On 3/14/2017 7:31 PM, Sergey Bylokhov wrote:
>>>> The initial image at [1] also show some issues in the submenu 
>>>> pointer and the menu corners, did we solve them already?
>>>   The submenu icon is updated in the current fix and the issue with 
>>> a menu corner is covered by the fix
>>>     JDK-8162350 RepaintManager shifts repainted region when the 
>>> floating point UI scale is used
>> Thanks, Looks fine.
>>
>>>   Thanks,
>>>   Alexandr.
>>>> [1] 
>>>> http://stackoverflow.com/questions/41117190/java-9-on-windows-with-large-fonts
>>>>
>>>>> Hello,
>>>>>
>>>>> Could you review the fix:
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8174845
>>>>> webrev: 
>>>>> http://cr.openjdk.java.net/~alexsch/8174845/webrev.00<http://cr.openjdk.java.net/%7Ealexsch/8174845/webrev.00>
>>>>>
>>>>> Metal JCheckBox and JMenuItem icons are updated to be drawn by 
>>>>> ovals, arcs and polygons.
>>>>>
>>>>> The [1] folder contains screenshots how icons are drawn before the 
>>>>> fix (on the left side) and after the fix (on the right side) with 
>>>>> Default and Ocean Metal themes.
>>>>>
>>>>> [1] 
>>>>> http://cr.openjdk.java.net/~alexsch/8174845/screenshots/00<http://cr.openjdk.java.net/%7Ealexsch/8174845/screenshots/00>
>>>>>
>>>>> Thanks,
>>>>> Alexandr.
>>>>>