<Swing Dev> <Sound Dev> [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

[Jonathan Gibbons]

Sergey,

This is not a comment on the content of the review; it is a minor 
comment on your interpretation of <p>.

<p> is a block-level tag that is implicitly terminated by any of many 
block-level tags. For the full list, see the W3C definition of the p 
element in HTML 5:
https://www.w3.org/TR/html5/grouping-content.html#the-p-element

> Tag omission in text/html 
> <https://www.w3.org/TR/html5/dom.html#element-dfn-tag-omission>:
>
>     A |p
>     <https://www.w3.org/TR/html5/grouping-content.html#the-p-element>|
>     element's end tag
>     <https://www.w3.org/TR/html5/syntax.html#syntax-end-tag> may be
>     omitted if the |p
>     <https://www.w3.org/TR/html5/grouping-content.html#the-p-element>|
>     element is immediately followed by an |address
>     <https://www.w3.org/TR/html5/sections.html#the-address-element>|,
>     |article
>     <https://www.w3.org/TR/html5/sections.html#the-article-element>|,
>     |aside
>     <https://www.w3.org/TR/html5/sections.html#the-aside-element>|,
>     |blockquote
>     <https://www.w3.org/TR/html5/grouping-content.html#the-blockquote-element>|,
>     |div
>     <https://www.w3.org/TR/html5/grouping-content.html#the-div-element>|,
>     |dl
>     <https://www.w3.org/TR/html5/grouping-content.html#the-dl-element>|,
>     |fieldset
>     <https://www.w3.org/TR/html5/forms.html#the-fieldset-element>|,
>     |footer
>     <https://www.w3.org/TR/html5/sections.html#the-footer-element>|,
>     |form <https://www.w3.org/TR/html5/forms.html#the-form-element>|,
>     |h1
>     <https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements>|,
>     |h2
>     <https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements>|,
>     |h3
>     <https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements>|,
>     |h4
>     <https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements>|,
>     |h5
>     <https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements>|,
>     |h6
>     <https://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements>|,
>     |header
>     <https://www.w3.org/TR/html5/sections.html#the-header-element>|,
>     |hgroup <https://www.w3.org/TR/html5/obsolete.html#hgroup>|, |hr
>     <https://www.w3.org/TR/html5/grouping-content.html#the-hr-element>|,
>     |main
>     <https://www.w3.org/TR/html5/grouping-content.html#the-main-element>|,
>     |nav <https://www.w3.org/TR/html5/sections.html#the-nav-element>|,
>     |ol
>     <https://www.w3.org/TR/html5/grouping-content.html#the-ol-element>|,
>     |p
>     <https://www.w3.org/TR/html5/grouping-content.html#the-p-element>|, |pre
>     <https://www.w3.org/TR/html5/grouping-content.html#the-pre-element>|,
>     |section
>     <https://www.w3.org/TR/html5/sections.html#the-section-element>|,
>     |table
>     <https://www.w3.org/TR/html5/tabular-data.html#the-table-element>|, or
>     |ul
>     <https://www.w3.org/TR/html5/grouping-content.html#the-ul-element>|,
>     element, or if there is no more content in the parent element and
>     the parent element is not an |a
>     <https://www.w3.org/TR/html5/text-level-semantics.html#the-a-element>|
>     element.
>


-- Jon

On 05/05/2017 12:37 PM, Sergey Bylokhov wrote:
> Hi, Alexey.
> Yes it is possible to add </p> to this changes, but actually </p> tag is not used in JavaSound docs. The last one were removed a few years ago. The <p> tag is used in assumption that it affect the text till the next <p> or till the end of the doc.
> So for example in the MidiMessage.java/SizeSequence.java there are a few <p> tags which affects the text till the next <p>, and in this fix just one more <p> was added in the middle.
>
> ----- alexey.menkov at oracle.com wrote:
>
>> Overall looks good.
>> One minor point - there are several places when you replace <center>
>> with <p> without end </p>.
>> Usually absent </p> doesn't cause any problem, but it would be better
>> to
>> have end tags for all elements.
>>
>> I see this in
>> src/java.desktop/share/classes/javax/sound/midi/MidiMessage.java
>> src/java.desktop/share/classes/javax/sound/sampled/FloatControl.java
>> src/java.desktop/share/classes/javax/sound/sampled/TargetDataLine.java
>> src/java.desktop/share/classes/javax/swing/SizeSequence.java
>>
>> --alex
>>
>> On 05/04/2017 18:15, Sergey Bylokhov wrote:
>>> Hello,
>>> Please review the fix for jdk9-dev.
>>> This fix is a part of the effort to make all javadoc in jdk9 be
>> compatible to HTML5.
>>> In the fix the most common issues are fixed.
>>> The issues related to tables will be fixed later, because it is
>> depends from the new html styles which are under review[1].
>>> After the fix the number of errors reported during the build in
>> java.desktop module decreased from 300+ to 110.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8179596
>>> Webrev can be found at:
>> http://cr.openjdk.java.net/~serb/8179596/webrev.00
>>> Specdiff: http://cr.openjdk.java.net/~serb/8179596/specdiff.00
>>>
>>> [1]
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047433.html

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20170505/615d5fde/attachment.html>