<Swing Dev> [10] RFR JDK-7042497: javax.swing.JOptionPane.showInternalConfirmDialog throws RuntimeException

[Semyon Sadetsky]

Also the spec says to use the default frame but the fix creates new 
frame each time.


On 05/12/2017 07:32 AM, Semyon Sadetsky wrote:
>
> The fix covers the parentComponent=null case.
>
> What about the second case when non-null component is provided but it 
> has no frame?
>
> --Semyon
>
>
> On 05/12/2017 12:51 AM, Prasanta Sadhukhan wrote:
>>
>> Hi All,
>>
>> Please review a spec violation issue whereby if in 
>> JOptionPane.showInternalConfirmDialog(Component parentComponent, 
>> Object message)
>> "parentComponent" is null, we are getting RuntimeException 
>> "parentComponent does not have a valid parent"
>>
>> but as per spec, 
>> https://docs.oracle.com/javase/8/docs/api/index.html?javax/swing/JOptionPane.html
>> it says "|parentComponent| - determines the |Frame| in which the 
>> dialog is displayed; if |null|, or if the |parentComponent| has no 
>> |Frame|, a default |Frame| is used"
>>
>> This violation exists for all overridden showInternalConfirmDialog 
>> methods and showInternalOptionDialog.
>>
>> The proposed fix creates a default JFrame and shows the confirm 
>> dialog in it, as stated in the spec.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-7042497
>> webrev: http://cr.openjdk.java.net/~psadhukhan/7042497/webrev.00/
>>
>> Regards
>> Prasanta 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20170512/ab76767c/attachment.html>