<Swing Dev> [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

[Jonathan Gibbons]

On 05/12/2017 05:03 PM, Philip Race wrote:
>
>
> On 5/12/17, 4:58 PM, Jonathan Gibbons wrote:
>> Phil,
>>
>> 1. javadoc now provides support for 3 named styles in the default 
>> stylesheet:
>>         borderless:  no borders
>>         plain:  simple 1px borders around tables and cells
>>         striped: reduced borders; rows have alternating white and 
>> light grey backgrounds
>>
> OK .. I see these being used.
>>
>> 2. summary attributes are not legal in HTML 5.
>>     For accessibility reasons, you should consider having a table 
>> caption instead.
>
> OK. I saw these but I wasn't clear it was a direct replacement. HTML 5 
> sometimes
> seems to be different just to be different ..

It's not a direct replacement. The summary attribute was used to give a 
more descriptive value
of the contents of the table.   A caption is more like a title. But the 
ARIA guidelines essentially
say, use one or the other, unless you want to dig deeper into aria 
attributes (not recommended.)

>
> -phil.
>>
>> -- Jon
>>
>>
>> On 05/12/2017 04:54 PM, Philip Race wrote:
>>> Does this in any way match the rest of the docs ? Or is everyone 
>>> left to style things how they want.
>>> I thought (?) maybe there is to be some javadoc tool support for CSS 
>>> styles.
>>>
>>> Also why are all the table summaries removed ?
>>>
>>> -phil.
>>>
>>> On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
>>>> This is because I use the same style for most of the tables 
>>>> 'class="striped"', which apply the same/unified style for all(most) 
>>>> of our tables.
>>>> Also this is because I removed 'inlined' styles, like here:
>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>>
>>>>
>>>> ----- philip.race at oracle.com wrote:
>>>>
>>>>> Adding 2d-dev because a number of the files are 2D.
>>>>>
>>>>> What is the general reason for changing the appearance of the tables?
>>>>>
>>>>> -phil.
>>>>>
>>>>> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
>>>>>> Hello,
>>>>>> Please review the fix for jdk9-dev.
>>>>>>
>>>>>> This fix is a part of the effort to make all javadoc in jdk9 be
>>>>> compatible to HTML5.
>>>>>> It covers all errors which are reported by the javadoc tool during
>>>>> the build of jdk for java.desktop module.
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180326
>>>>>> Webrev can be found at:
>>>>> http://cr.openjdk.java.net/~serb/8180326/webrev.01
>>>>>> Note that an appearance of some tables were changed after the fix:
>>>>>>
>>>>>> Before:
>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/java/awt/font/TextAttribute.html 
>>>>>
>>>>>> After:
>>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/java/awt/font/TextAttribute.html 
>>>>>
>>>>>> Before:
>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioSystem.html 
>>>>>
>>>>>> After :
>>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioSystem.html 
>>>>>
>>>>>> Before:
>>>>> http://cr.openjdk.java.net/~serb/8180326/api_old.01/javax/sound/sampled/AudioPermission.html 
>>>>>
>>>>>> After:
>>>>> http://cr.openjdk.java.net/~serb/8180326/api.01/javax/sound/sampled/AudioPermission.html 
>>>>>
>>