<Swing Dev> [OpenJDK 2D-Dev] [10] Review Request JDK - 8164811 : [hidpi]Tests fail with OpenGL Rendering

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Nov 7 08:15:01 UTC 2017

Thanks for clarification. Looks fine.
One more thing which can improve the fix is to add "uiScale > 1.0" as an 
additional @run step to the tests, so these tests will fail before the 
fix even on common lowdpi(100%) systems.

On 06/11/2017 23:20, Pankaj Bansal wrote:
> I am assuming you are talking about changes in UpdateWindow function in TranslucentPainter.
> I think it is doing exactly what was happening before the fix. It called getBackBuffers and saved it in bb initially and then,  If the update fails, "done" will be false and it was calling getBackBuffers (true) to save the buffer in bb everytime. So it was calling getBackBuffers() everytime the update fails. Also the createBackBuffers function is creating backbuffer only once and then just returning it if the width and height remains same. So when I call update(getBackBuffers(false)), it will just return the backBuffers, not create it. So this change has added a call to getBackBuffers, but without it, I will have to add a check to see if the Image is BufferedImage or VolatileImage to decide to transform the Graphics or not.

More information about the swing-dev mailing list