<Swing Dev> [10] Review request for 8180821: [macosx]com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java: The menu item should have been GC-ed

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Thu Oct 12 05:37:00 UTC 2017


You need to add the bugid to @bug tag. +1 otherwise.

Regards
Prasanta
On 10/12/2017 12:33 AM, Phil Race wrote:
> If it makes the test pass ..
>
> +1
>
>
> -phil.
>
>
> On 10/11/2017 11:37 AM, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK10 (the changes involve AWT and Swing):
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8180821
>>
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8180821/webrev.00/
>>
>> This is a test bug. The test fails intermittently because the 
>> System.runFinalization() method invocation just triggers the 
>> finalization thread in parallel so it may be not accomplished yet 
>> after the method exits. Adding 1s delay makes the test passing stably.
>>
>> --Semyon
>>
>




More information about the swing-dev mailing list