<Swing Dev> [8u] Review request for 8166772: Touch keyboard is not shown for text components on a screen touch

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Oct 13 22:38:42 UTC 2017


Looks fine.

On 13/10/2017 11:54, Anton Litvinov wrote:
> Hello Sergey and Alexander,
> 
> Could you please review the following back port of the fix, which you 
> already reviewed for JDK 10, from JDK 10 to JDK 8.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8166772
> JDK 8 webrev: http://cr.openjdk.java.net/~alitvinov/8166772/jdk8/webrev.00
> JDK 10 changeset: http://hg.openjdk.java.net/jdk10/client/rev/3b244a98d5ab
> JDK 10 webrev: 
> http://cr.openjdk.java.net/~alitvinov/8166772/jdk10/webrev.01
> 
> The back port fix is identical to the original fix for JDK 10, except 
> for the next micro changes:
> 
> 1.  "SunToolkit.java" file - In JDK 8 version of the fix 
> "AccessController.doPrivileged(new GetPropertyAction(" is used instead 
> of "GetPropertyAction.privilegedGetProperty(", since 
> "GetPropertyAction.privilegedGetProperty" does not exist in JDK 8.
> 
> 2.  "WToolkit.java" file - In JDK 8 version of the fix the import 
> statement "import sun.awt.AWTAccessor;" was added.
> 
> Thank you,
> Anton


-- 
Best regards, Sergey.



More information about the swing-dev mailing list