<Swing Dev> [10][JDK-6714836] JRootPane.getMaximumSize() returns a width of 0

[Krishna Addepalli]

Done that!

 

http://cr.openjdk.java.net/~pkbalakr/Krishna/6714836/webrev02/  is the updated webrev.

 

Thanks,

Krishna

 

From: Prasanta Sadhukhan 
Sent: Monday, September 4, 2017 5:45 PM
To: Krishna Addepalli <krishna.addepalli at oracle.com>; swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> [10][JDK-6714836] JRootPane.getMaximumSize() returns a width of 0

 

Looks fine. But, remove @author tag as we do not use it anymore. Also, @modules tag is used to add some internal modules if test needs one, here it is not needed, so you remove that too. Add @run tag.

Regards
Prasanta

On 9/4/2017 3:46 PM, Krishna Addepalli wrote:

Hi Prasanta,

 

Thanks for bringing that up. I have updated the webrev with the test case. 

 

JDK 10 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/Krishna/6714836/webrev.01/"http://cr.openjdk.java.net/~pkbalakr/Krishna/6714836/webrev.01/

 

Krishna

 

From: Prasanta Sadhukhan 
Sent: Thursday, August 24, 2017 1:50 PM
To: Krishna Addepalli HYPERLINK "mailto:krishna.addepalli at oracle.com"<krishna.addepalli at oracle.com>; HYPERLINK "mailto:swing-dev at openjdk.java.net"swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> [10][JDK-6714836] JRootPane.getMaximumSize() returns a width of 0

 

You can add a regression test with the fix as JBS already has one.

Regards
Prasanta

On 8/24/2017 12:37 PM, Krishna Addepalli wrote:

Hi All, 

 

Bug : JDK- 6714836 <https://bugs.openjdk.java.net/browse/JDK-6714836>

JDK 10 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/Krishna/6714836/webrev00/"http://cr.openjdk.java.net/~pkbalakr/Krishna/6714836/webrev00/

 

The issue is that when a text label is added to JRootPane and query the maximumLayoutSize, it is returning 0. The root cause is because, JRootPane decides to provide the Minimum width of Menubar (which in this case is 0) and the content pane (which contains the JLabel). Actually, it should return the maximum of the two, since that is what is the layout size needed.

 

Thanks,

Krishna

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20170905/ce815ba9/attachment.html>