<Swing Dev> [11] [JDK-8201173] Remove duplicated code in AbstractListModel class

Krishna Addepalli krishna.addepalli at oracle.com
Thu Apr 5 15:38:47 UTC 2018


Hi All, 

Please review a fix for 

JDK-8201173: https://bugs.openjdk.java.net/browse/JDK-8201173

Webrev: http://cr.openjdk.java.net/~kaddepalli/8201173/webrev00/

 

There is the duplication of code in fireContentsChanged, fireIntervalAdded, fireIntervalRemoved functions, barring an int parameter and a function call.

Moved the common code into a function called fireUpdates, and defined a functional interface, so that each function can pass its own lambda that does the requisite function call.

 

I have run the tests for JList and JComboBox and observed no new failures.

 

Thanks,

Krishna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20180405/92c32f77/attachment.html>


More information about the swing-dev mailing list