<Swing Dev> [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel should support addAll (Collection c)

Andrej Golovnin andrej.golovnin at gmail.com
Mon Apr 9 09:44:34 UTC 2018


Hi Krishna,

> Please review a simple fix for enhancement:
>
> JDK-4842658: https://bugs.openjdk.java.net/browse/JDK-4842658
>
> Webrev: http://cr.openjdk.java.net/~kaddepalli/4842658/webrev00/
>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8201289


src/java.desktop/share/classes/javax/swing/DefaultComboBoxModel.java

195         fireIntervalAdded(this, startIndex, getSize());

It should be:

195         fireIntervalAdded(this, startIndex, getSize() - 1);


221         fireIntervalAdded(this, index, index + c.size());

It should be:

221         fireIntervalAdded(this, index, index + c.size() - 1);


src/java.desktop/share/classes/javax/swing/DefaultListModel.java

574         if(c.isEmpty()) {

There should be a space after 'if'.

Best regards,
Andrej Golovnin



More information about the swing-dev mailing list