<Swing Dev> [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

Andrej Golovnin andrej.golovnin at gmail.com
Tue Apr 10 08:47:54 UTC 2018


Hi Pankaj,

> Webrev:
>
> http://cr.openjdk.java.net/~pbansal/8194873/webrev.01/

src/java.desktop/windows/native/libawt/windows/awt_Component.cpp

3540         BOOL altIsDown = ((modifiers &
java_awt_event_InputEvent_ALT_DOWN_MASK) ||
3541                             (modifiers &
java_awt_event_InputEvent_ALT_DOWN_MASK));

Applying '||' on the same value does not make sense. I think the line
3541 should use 'java_awt_event_InputEvent_ALT_GRAPH_DOWN_MASK':

3541                             (modifiers &
java_awt_event_InputEvent_ALT_GRAPH_DOWN_MASK));

Best regards,
Andrej Golovnin



More information about the swing-dev mailing list