<Swing Dev> [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

[Phil Race]

+1 (but don't forget to update the CSR and wait for that approval).

-phil


On 4/11/2018 12:06 PM, Pankaj Bansal wrote:
>
> Hi Phil,
>
> Thanks for the review.
>
> <<Can we change all occurrences of @exception -> @throws in this method ?
> <<In fact this method appears to be the only one in this class to use 
> @exception
> <<so it is doubly anomalous.
>
> Done.
>
> Webrev: http://cr.openjdk.java.net/~pbansal/8153532/webrev.01/ 
> <http://cr.openjdk.java.net/%7Epbansal/8153532/webrev.01/>
>
> Regards,
>
> Pankaj Bansal
>
> *From:*Phil Race
> *Sent:* Thursday, April 12, 2018 12:08 AM
> *To:* Krishna Addepalli; Pankaj Bansal; swing-dev at openjdk.java.net
> *Subject:* Re: <Swing Dev> [11][JDK-8153532] RFR: Add @throws NPE 
> javadoc to UIManager.setLookAndFeel(String) method description
>
> Can we change all occurrences of @exception -> @throws in this method ?
> In fact this method appears to be the only one in this class to use 
> @exception
> so it is doubly anomalous.
>
> -phil.
>
> On 04/10/2018 04:07 AM, Krishna Addepalli wrote:
>
>     Hi Pankaj,
>
>     The change looks fine to me.
>
>     Thanks,
>
>     Krishna
>
>     *From:* Pankaj Bansal
>     *Sent:* Tuesday, April 10, 2018 4:27 PM
>     *To:* swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
>     *Subject:* <Swing Dev> [11][JDK-8153532] RFR: Add @throws NPE
>     javadoc to UIManager.setLookAndFeel(String) method description
>
>     Hi All,
>
>     Please review a very simple fix for documentation change enhancement:
>
>     JDK-8153532: https://bugs.openjdk.java.net/browse/JDK-8153532
>
>     Webrev: http://cr.openjdk.java.net/~pbansal/8153532/webrev.00/
>     <http://cr.openjdk.java.net/%7Epbansal/8153532/webrev.00/>
>
>     CSR: https://bugs.openjdk.java.net/browse/JDK-8201363
>
>     UIManager.setLookAndFeel (String) throws NPE if the className is
>     null. But this is not updated in the API description. Made changes
>     for the same.
>
>     Regards,
>
>     Pankaj Bansal
>