<Swing Dev> [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Aug 13 18:04:37 UTC 2018


On 11/08/2018 15:46, Philip Race wrote:
> If you mean, update the code so it is shared across L+Fs that can be a 
> future project.
> No matter how "easy" that is, it will take extra time and add risk. Not 
> for 11.

My point was to move the whole fix out from jdk11, since it is not a 
regression in 11, works as a native cocoa components, and duplicate 300 
lines of code.

> 
> -phil.
> 
> On 8/11/18, 3:14 PM, Sergey Bylokhov wrote:
>> Hi, Krishna.
>> Is it possible to deduplicate this code, I guess it should.
>>
>> On 11/08/2018 08:21, Krishna Addepalli wrote:
>>> Hi All,
>>>
>>> Please review a fix for JDK-8208640: 
>>> https://bugs.openjdk.java.net/browse/JDK-8208640
>>>
>>> Webrev: http://cr.openjdk.java.net/~kaddepalli/8208640/webrev00/ 
>>> <http://cr.openjdk.java.net/%7Ekaddepalli/8208640/webrev00/>
>>>
>>> The problem is that the arrow key navigation for Aqua L&F was not 
>>> implemented, which is why neither the tab keys nor the arrow keys 
>>> were allowing to navigate through the radio buttons through a button 
>>> group.
>>>
>>> Proposed fix is to copy the implementation from Basic L&F into Aqua 
>>> L&F. Also fixed the test that was written to include the Aqua L&F to 
>>> be tested, and it passes on Mac successfully.
>>>
>>> Thanks,
>>>
>>> Krishna
>>>
>>
>>


-- 
Best regards, Sergey.



More information about the swing-dev mailing list