<Swing Dev> [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

[Prasanta Sadhukhan]

ok. in that case, fix looks good. You will need a CSR.

I guess the test will fail compilation without fix so no exception will 
be thrown but I guess we cannot escape that.

Regards
Prasanta
On 8/29/2018 6:50 PM, Krishna Addepalli wrote:
>
> I presume you are hinting at binary compatibility. I think, that 
> should not be an issue, since we are not modifying any of the existing 
> functions, but adding a new function. So, I don’t think there would be 
> any linking issues. Correct me if I’m wrong.
>
> Thanks,
>
> Krishna
>
> *From:*Krishna Addepalli
> *Sent:* Wednesday, August 29, 2018 5:29 PM
> *To:* Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com>; 
> swing-dev at openjdk.java.net
> *Subject:* RE: <Swing Dev> [12]RFR:JDK-8182041- FIle Chooser Shortcut 
> Panel folders under on JDK9
>
> But we cannot have default methods in abstract classes. Only 
> interfaces allow that.
>
> Thanks,
>
> Krishna
>
> *From:*Prasanta Sadhukhan
> *Sent:* Wednesday, August 29, 2018 3:21 PM
> *To:* Krishna Addepalli <krishna.addepalli at oracle.com>; 
> swing-dev at openjdk.java.net
> *Subject:* Re: <Swing Dev> [12]RFR:JDK-8182041- FIle Chooser Shortcut 
> Panel folders under on JDK9
>
> On 8/29/2018 2:23 PM, Krishna Addepalli wrote:
>
>     Hi Prasanta,
>
>     The new method “getChooserShortcutPanelFiles”, and the method
>     “getChooserComboBoxFiles” are present in FileSystemView class
>     itself, which makes it a default implementation already.
>
> I doubt that. If an application has extended jdk9 FileSystemView class 
> and has its own implementation for its OS, then it probably will not 
> link with jdk12 modified FileSystemView class as it contains a new method.
> Probably, you should consider adding "default" keyword to your new method.
>
> Regards
> Prasanta
>
>     As for the string “fileChooserShortcutPanelFolders”, it goes to OS
>     specific implementation and provides appropriate result as per the
>     underlying OS.
>
>     Thanks,
>
>     Krishna
>
>     *From:*Prasanta Sadhukhan
>     *Sent:* Wednesday, August 29, 2018 2:07 PM
>     *To:* Krishna Addepalli <krishna.addepalli at oracle.com>
>     <mailto:krishna.addepalli at oracle.com>; swing-dev at openjdk.java.net
>     <mailto:swing-dev at openjdk.java.net>
>     *Subject:* Re: <Swing Dev> [12]RFR:JDK-8182041- FIle Chooser
>     Shortcut Panel folders under on JDK9
>
>     Hi Krishna,
>
>     One more thing...it is mentioned here
>
>     58  * Java Licensees may want to provide a different implementation of
>
>        59  * FileSystemView to better handle a given operating system
>
>       
>
>     If this class is ever extended by applications, then would it not be source incompatible change as there is no default
>
>     implementation of the new method?
>
>       
>
>     Regards
>
>     Prasanta
>
>     On 8/27/2018 5:05 PM, Krishna Addepalli wrote:
>
>         Hi Prasanta,
>
>         Thanks for pointing those out. Corrected them in the new
>         webrev:
>         http://cr.openjdk.java.net/~kaddepalli/8182041/webrev01/
>         <http://cr.openjdk.java.net/%7Ekaddepalli/8182041/webrev01/>
>
>         Krishna
>
>         *From:*Prasanta Sadhukhan
>         *Sent:* Monday, August 27, 2018 4:50 PM
>         *To:* Krishna Addepalli <krishna.addepalli at oracle.com>
>         <mailto:krishna.addepalli at oracle.com>;
>         swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
>         *Subject:* Re: <Swing Dev> [12]RFR:JDK-8182041- FIle Chooser
>         Shortcut Panel folders under on JDK9
>
>         Hi Krishna,
>
>         Quick comments:
>         @since 10 should be @since 12 in API javadoc
>         Is ShellFolderQueriesSecurityManagerTest a manual test as you
>         mentioned
>
>         @run main/manual/
>
>
>         Regards
>         Prasanta
>
>         On 8/27/2018 4:24 PM, Krishna Addepalli wrote:
>
>             Hi All,
>
>             Please review fix for JDK10 (the changes involve AWT and
>             Swing):
>
>             bug: https://bugs.openjdk.java.net/browse/JDK-8182041
>
>             webrev:
>             http://cr.openjdk.java.net/~kaddepalli/8182041/webrev00/
>             <http://cr.openjdk.java.net/%7Ekaddepalli/8182041/webrev00/>
>
>             New API method was added to query shortcut panel entries
>             for JFileChooser, since ShellFolder is internal class
>             which is not publicly accessible.
>
>             Thanks,
>
>             Krishna
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20180830/63d57334/attachment.html>