<Swing Dev> [11] RFR JDK-8186513:TESTBUG] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java

[Semyon Sadetsky]

+1

--Semyon


On 02/27/2018 08:11 AM, Prasanta Sadhukhan wrote:
> Hi Jay,
>
>
> On 2/27/2018 9:35 PM, Jayathirth D V wrote:
>> Hi Prasanta,
>>
>> Just doing setUndecorated(true) is making the test pass in my windows 
>> 7 system.
>> Was there any specific problem in other platforms with respect to 
>> reading rgb value from the edge?
> Yes, for linux ubuntu 17.10...It seems we have the task bar at the 
> left so it might be creating some problem reading value at the edge, 
> so that was added to make it read inside the edge.
>
> Regards
> Prasanta
>> Also the newly added println is fine but please add space between 
>> first and second argument which will help to read the debug 
>> information properly before pushing.
>>
>> Thanks,
>> Jay
>>
>> -----Original Message-----
>> From: Prasanta Sadhukhan
>> Sent: Tuesday, February 27, 2018 2:30 PM
>> To: swing-dev at openjdk.java.net
>> Subject: <Swing Dev> [11] RFR JDK-8186513:TESTBUG] 
>> javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
>>
>> Hi All,
>>
>> Please review a testfix for an issue in which test fails citing 
>> "background color is wrong" in windows, linux,mac.
>> It seems test tries to get the rgb value for screen capture from x=0 
>> and if it does not match the background color of Orange, then it fails.
>>
>> Modified testcase to test the rgb value from x=1 position to avoid 
>> any blending effect at the edge of windows.
>> Also, made the frame undecorated so that insets does not cause any 
>> blending problem at the edge.
>> Tested in windows7, ubuntu17.10 and mac10.13.3 and it works fine.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8186513
>> webrev: http://cr.openjdk.java.net/~psadhukhan/8186513/webrev.00/
>>
>> Regards
>> Prasanta
>