<Swing Dev> [11] Review Request: JDK-5076761 : JList.setSelectedValue(null, ...) doesn't do anything
Andrej Golovnin
andrej.golovnin at gmail.com
Fri Jan 5 11:03:21 UTC 2018
Hi Pankaj,
> Webrev: http://cr.openjdk.java.net/~pbansal/5076761/webrev.02/
src/java.desktop/share/classes/javax/swing/JList.java
You can simplify the code in lines
2373 if((anObject == selectedValue) ||
2374 (anObject != null && anObject.equals(selectedValue))) {
and
2383 if ((anObject == object) ||
2384 anObject!= null && anObject.equals(object)) {
by using Objects.equals(Object, Object):
And please add spaces in the line 2379 where needed (see
http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-whitespace
for details).
Best regards,
Andrej Golovnin
More information about the swing-dev
mailing list