<Swing Dev> [11] Review Request: JDK-5076761 : JList.setSelectedValue(null, ...) doesn't do anything

[Semyon Sadetsky]

Hi Pankaj,

Note that before the selection was never cleared if the object is not 
found and the DefaultListSelecetionModel is used. This may cause 
compatibility issue in old applications.

Since the clearing selection behavior is now mentioned in 
setSelectedValue() javadoc it should be also clarified for

setSelectedIndex()
setSelectedIndices()
setSelectionInterval()

and their implementation may need to be changed as well to be consistent.

--Semyon

On 01/05/2018 06:09 AM, Pankaj Bansal wrote:
> Hi Andrej,
>
> Sorry I missed this small thing. Following is the new webrev
> webrev: http://cr.openjdk.java.net/~pbansal/5076761/webrev.04/
>
> Regards,
> Pankaj Bansal
>
> -----Original Message-----
> From: Andrej Golovnin [mailto:andrej.golovnin at gmail.com]
> Sent: Friday, January 5, 2018 6:52 PM
> To: Pankaj Bansal
> Cc: Semyon Sadetsky; swing-dev at openjdk.java.net; Sergey Bylokhov
> Subject: Re: <Swing Dev> [11] Review Request: JDK-5076761 : JList.setSelectedValue(null, ...) doesn't do anything
>
> Hi Pankaj,
>
>> Webrev: http://cr.openjdk.java.net/~pbansal/5076761/webrev.03/
> src/java.desktop/share/classes/javax/swing/JList.java
>
> 2379             for(i = 0, c = dm.getSize(); i < c; i++) {
>
> There should be a space after "for". Otherwise looks good. Thanks!
>
> Best regards,
> Andrej Golovnin