<Swing Dev> [12] RFR: JDK-8206343: There is a typo in the java documentation of javax.swing.JScrollBar.

[Philip Race]

One more ! I did not notice this typo from you at 365 until now

+     * Some look and feel imlementations that provide custom scrolling


imlementations ->  implementations

Fix this and push (I don't need to review again as long as it is fixed).

-phil.


On 7/18/18, 10:18 PM, Krishna Addepalli wrote:
>
> Hi Phil,
>
> I have incorporated the changes you suggested.
>
> Here is the new webrev: 
> http://cr.openjdk.java.net/~kaddepalli/8206343/webrev02/ 
> <http://cr.openjdk.java.net/%7Ekaddepalli/8206343/webrev02/>
>
> Thanks,
>
> Krishna
>
> *From:*Philip Race
> *Sent:* Wednesday, July 18, 2018 10:18 PM
> *To:* Krishna Addepalli <krishna.addepalli at oracle.com>
> *Cc:* swing-dev at openjdk.java.net
> *Subject:* Re: <Swing Dev> [12] RFR: JDK-8206343: There is a typo in 
> the java documentation of javax.swing.JScrollBar.
>
> A few things still need fixing, the end result should look like this :
>   
> +     * value.   Subclasses may override this method to compute
> +     * a value, e.g. the change required to scroll one
>        * (variable height) line of text or one row in a table.
>   
> +     * then most look and feel implementations will not provide scrolling
> +     * to the right/down.
> +     * outside the scrollbar "knob" to scroll up or down by a large amount.
> +     * Subclasses may override this method to compute a
> +     * value, e.g. the change required to scroll one paragraph
> +     * in a text document.
>   
> +     * then most look and feel implementations will not provide scrolling
> +     * to the right/down.
>
>
> -phil.
>
> On 7/18/18, 3:45 AM, Krishna Addepalli wrote:
>
>     Hi Phil,
>
>     I have reworded the sentences slightly so that it reads
>     grammatically correct to the best of my knowledge.
>
>     Here is the updated webrev:
>     http://cr.openjdk.java.net/~kaddepalli/8206343/webrev01/
>     <http://cr.openjdk.java.net/%7Ekaddepalli/8206343/webrev01/>
>
>     Thanks
>
>     Krishna
>
>     *From:*Phil Race
>     *Sent:* Monday, July 16, 2018 11:27 PM
>     *To:* Krishna Addepalli <krishna.addepalli at oracle.com>
>     <mailto:krishna.addepalli at oracle.com>; swing-dev at openjdk.java.net
>     <mailto:swing-dev at openjdk.java.net>
>     *Subject:* Re: <Swing Dev> [12] RFR: JDK-8206343: There is a typo
>     in the java documentation of javax.swing.JScrollBar.
>
>     Since you are updating these lines, maybe you could fix the grammar as well as the spelling ?
>
>       
>
>     -     * the most look and feels will not provide the scrolling to the right/down.
>
>     +     * then most look and feels will not provide the scrolling to the right/down.
>
>     -     * up or down by large amount.  Subclasses my override this
>
>     +     * up or down by large amount.  Subclasses may override this
>
>       
>
>     -     * the most look and feels will not provide the scrolling to the right/down.
>
>     +     * then most look and feels will not provide the scrolling to the right/down.
>
>       
>
>     -phil.
>
>     On 07/12/2018 04:46 AM, Krishna Addepalli wrote:
>
>         Hi All,
>
>         Please review a trivial typo corrections in JScrollbar. Apart
>         from those specified in the bug, I have also corrected few
>         others that I could find.
>
>         Bug: https://bugs.openjdk.java.net/browse/JDK-8206343
>
>         Webrev:
>         http://cr.openjdk.java.net/~kaddepalli/8206343/webrev00/
>         <http://cr.openjdk.java.net/%7Ekaddepalli/8206343/webrev00/>
>
>         Thanks,
>
>         Krishna
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20180718/f0c66bf0/attachment.html>